Commit graph

9328 commits

Author SHA1 Message Date
SomberNight
ad7f8f2cbe
wallet.py: fix balance/history for duplicate addresses
in a hd wallet, having duplicate addresses is extremely unlikely, but if it happened, previously an incorrect balance was calculated
2018-06-16 16:38:34 +02:00
SomberNight
59c1d03f01
ecc.py: properly handle point at infinity 2018-06-16 06:34:03 +02:00
SomberNight
1a8e8bc047
bitcoin.py: make int_to_hex throw on overflow 2018-06-16 02:34:27 +02:00
SomberNight
79f4a8bae9
ledger: support hiding outputs on 'receive' branch
so if change is on the 'receive' branch, user won't be prompted to confirm it
2018-06-15 20:48:57 +02:00
SomberNight
529cb3602c
fix ledger signing. fix dbb 2fa. follow-up partial txn ser change (#4405) 2018-06-15 20:21:29 +02:00
ghost43
a98e833897
getfeerate command: add optional parameters to specify custom fee level (#4264) 2018-06-15 17:02:44 +02:00
SomberNight
2cc15fca57
tests: add missing txid test from #3316 2018-06-15 15:39:09 +02:00
ghost43
cc05c09d6b
minikeys: import with uncompressed pubkey instead of compressed (#4384) 2018-06-15 15:32:00 +02:00
SomberNight
6297996d12
tests: (tx signing) offline hd multisig, online address 2018-06-15 15:07:56 +02:00
SomberNight
46fdbbbce5
change partial txn serialization format for imported addresses txins
offline signing with segwit WIF keys now works.
offline seed + online address signing now works.
2018-06-15 14:08:20 +02:00
SomberNight
d150f0dfc0
tests: rbf and cpfp 2018-06-15 14:05:30 +02:00
SomberNight
3e63a3cdc9
README: reference 'fast' extra instead of 'full'
'full' needs additional OS packages (for hw) that are not mentioned
2018-06-15 13:07:10 +02:00
SomberNight
00db9c4552
rerun freeze_packages
and remove rlp from requirements-hw as trezor no longer references it
2018-06-15 13:05:35 +02:00
SomberNight
6298e9b458
in Qt send tab, detect invalid multi-line payto when using "!": "insufficient funds"
if the rest of the amounts (without the "!") are over the available funds; do the correct thing
2018-06-14 23:34:14 +02:00
SomberNight
36ddb68384
synchronizer.py: fix bug where synchronizer would get stuck in case of weird server behaviour
there was some kind of re-org but our reorged transactions did not get into the server's mempool for some reason (and they were not mined either). the synchronizer detected the change in address status and asked for the new address histories but in `on_address_history` it thought it did not ask for the histories.

from log:
[Synchronizer] receiving history (unsolicited) 2N6DydVfmheVM9F94G46pcUi5piyffgNBQ9 0
[Synchronizer] receiving history (unsolicited) 2Mw6LDQUzmmxCX3wouDXo2Pj4wbonJATays 0
[SPV] received an error: {'jsonrpc': '2.0', 'error': {'code': 1, 'message': 'tx hash f7c89eec3454b627dcb8cfc822202a0d1f8b38f2a53db182b607a2f61e6946d1 not in block 000000007ac4e95633a16232bea35bc17edf855e3964dff0ebb108b5887647ff at height 1,325,443'}, 'id': 120, 'method': 'blockchain.transaction.get_merkle', 'params': ['f7c89eec3454b627dcb8cfc822202a0d1f8b38f2a53db182b607a2f61e6946d1', 1325443]}
2018-06-14 23:31:19 +02:00
SomberNight
9365b0f924
RBF: better exception handling 2018-06-14 22:36:54 +02:00
SomberNight
1b834a7a78
fix RBF 2018-06-14 22:19:06 +02:00
SomberNight
8f7a4cf876
follow-up 0438bbc2c2
the previous was quadratic in len(tx.inputs())
2018-06-14 21:46:03 +02:00
SomberNight
7ebff5616e
ecc.py: _MyVerifyingKey.from_signature is raising low level exception
Traceback (most recent call last):
  File "...\electrum\gui\qt\util.py", line 645, in run
    result = task.task()
  File "...\electrum\lib\wallet.py", line 1500, in sign_transaction
    k.sign_transaction(tx, password)
  File "...\electrum\plugins\keepkey\keepkey.py", line 67, in sign_transaction
    self.plugin.sign_transaction(self, tx, prev_tx, xpub_path)
  File "...\electrum\plugins\keepkey\keepkey.py", line 263, in sign_transaction
    tx.update_signatures(signatures)
  File "...\electrum\lib\transaction.py", line 667, in update_signatures
    public_key = ecc.ECPubkey.from_sig_string(sig_string, recid, pre_hash)
  File "...\electrum\lib\ecc.py", line 180, in from_sig_string
    ecdsa_verifying_key = _MyVerifyingKey.from_signature(sig_string, recid, msg_hash, curve=SECP256k1)
  File "...\electrum\lib\ecc.py", line 152, in from_signature
    Q = inv_r * ( s * R + minus_e * G )
  File "...\Python\Python36-32\lib\site-packages\ecdsa\ellipticcurve.py", line 143, in __rmul__
    return self * other
  File "...\electrum\lib\ecc_fast.py", line 120, in mul
    public_pair_bytes = b'\4' + self.x().to_bytes(32, byteorder="big") + self.y().to_bytes(32, byteorder="big")
OverflowError: int too big to convert
2018-06-14 20:14:38 +02:00
SomberNight
0438bbc2c2
transaction.py: change update_signatures API. fix trezor segwit signing.
Traceback (most recent call last):
  File "...\electrum\lib\transaction.py", line 498, in parse_witness
    if txin['witness_version'] != 0:
KeyError: 'witness_version'
2018-06-14 20:13:04 +02:00
SomberNight
05e5ef16eb
transaction.py: more flexible sign() method
handles both x_pubkeys and pubkeys in keypairs
2018-06-14 15:11:20 +02:00
SomberNight
5d7157451f
tests: TestWalletOfflineSigning 2018-06-13 19:27:07 +02:00
SomberNight
11ffc5ca8a
wallet.py: remove placeholder code re p2sh imported wallets 2018-06-13 19:23:09 +02:00
SomberNight
4193c7ff14
transaction.py: wtxid is undefined for uncomplete txns 2018-06-13 19:22:04 +02:00
SomberNight
e8b5bcf31e
fix incorrect txid for partial segwit txns
follow-up #4405
2018-06-13 15:54:45 +02:00
SomberNight
12c5474cf1
stricter tx deserialization: forbid negative output amount values 2018-06-12 14:41:30 +02:00
SomberNight
0b78cb5e6b
stricter tx deserialization: forbid output amount values over 21 million btc 2018-06-12 14:33:22 +02:00
Johann Bauer
5eb1cbef92 [WIP] Crash reports android (#3870)
* Split crash reporter class

In Qt related stuff and basic stuff.

* Crash reports from Android

* Ignore exceptions in crash_reporter (if any)

* Open issue in browser

* Switch back to real server
2018-06-12 14:17:34 +02:00
Janus
17ef023c8c icons: use non-flat lock/unlock icons, and rerender to 512x512 2018-06-12 12:30:44 +02:00
Janus
325e9b0d6f icons: fix viewbox of status_waiting and rerender 2018-06-12 12:20:52 +02:00
SomberNight
71ce7cce6d
stricter tx deserialization: forbid junk at the end 2018-06-12 10:51:51 +02:00
ThomasV
0e8976856d
Merge pull request #4429 from Anilkumar18/patch-2
Added a meaningful message on invalid public key
2018-06-12 10:49:16 +02:00
ThomasV
6f2396be34
Merge pull request #4435 from spesmilo/hi_res_old_icons
Add SVG icons resembling old raster icons
2018-06-12 10:35:03 +02:00
Anilkumar18
0a24c820bb
Altered the do_encrypt warning message
changed the protection against public_key
2018-06-12 11:16:02 +05:30
Janus
c2ac157f67 Add SVG icons resembling old raster icons 2018-06-11 21:39:40 +02:00
SomberNight
fa8707b390
trustedcoin kivy: fix restoring with "lost 2fa" option 2018-06-11 21:25:17 +02:00
ThomasV
ebdce9fb9a
Merge pull request #4405 from SomberNight/remove_from_addresses_from_wallet2
remove "from addresses"
2018-06-11 19:33:27 +02:00
SomberNight
6b8a563d41
add witness version to our partial format 2018-06-11 19:25:02 +02:00
SomberNight
a0ba5a7962
change partial txn format: add header. only parse inputs and witness for partial txns. 2018-06-11 17:57:29 +02:00
SomberNight
89040de758
remove "from addresses" from wallet logic 2018-06-11 17:55:31 +02:00
ThomasV
79558c1170 kivy wizard: replace checbox with button 2018-06-11 17:47:22 +02:00
ThomasV
e196d7b4d1 kivy: use TextInput to workaround Label texture size issue 2018-06-11 17:47:22 +02:00
SomberNight
1b36dd7690 fix "max" button to account for 2fa fees in both Qt and kivy 2018-06-11 17:47:22 +02:00
SomberNight
cf80952071 better handle exceptions in wizard re "cannot connect to trustedcoin server" 2018-06-11 17:47:22 +02:00
SomberNight
4fea9edd11 distinguish invalid otp from server failure when sending tx 2018-06-11 17:47:22 +02:00
SomberNight
27012e7394 tell user about 2fa fees when sending tx 2018-06-11 17:47:22 +02:00
SomberNight
396fa949b0 follow-up prev 2018-06-11 17:47:22 +02:00
SomberNight
531a2a5c1f during wallet restore allow user to retry after invalid OTP. add abort button on kivy. 2018-06-11 17:47:22 +02:00
SomberNight
248a3a5755 otp/email dialog handles pressing enter. do not offer to show seed for 2fa wallet. 2018-06-11 17:47:22 +02:00
ThomasV
9ceb73f014 follow-up a15b351b00c5a893c699c23111d8151377b8a262 2018-06-11 17:47:22 +02:00