From 9b30a4cb165eea378f18adbc7e86c2240fe48b60 Mon Sep 17 00:00:00 2001 From: Justin Li Date: Thu, 17 Jul 2014 13:16:27 -0400 Subject: [PATCH] Use literal dicts where possible for performance --- http/writer.go | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/http/writer.go b/http/writer.go index 18061fa..f6e6516 100644 --- a/http/writer.go +++ b/http/writer.go @@ -17,19 +17,20 @@ type Writer struct { } func (w *Writer) WriteError(err error) error { - dict := bencode.NewDict() - dict["failure reason"] = err.Error() - bencoder := bencode.NewEncoder(w) - return bencoder.Encode(dict) + + return bencoder.Encode(bencode.Dict{ + "failure reason": err.Error(), + }) } func (w *Writer) WriteAnnounce(res *models.AnnounceResponse) error { - dict := bencode.NewDict() - dict["complete"] = res.Complete - dict["incomplete"] = res.Incomplete - dict["interval"] = res.Interval - dict["min interval"] = res.MinInterval + dict := bencode.Dict{ + "complete": res.Complete, + "incomplete": res.Incomplete, + "interval": res.Interval, + "min interval": res.MinInterval, + } if res.IPv4Peers != nil || res.IPv4Peers != nil { if res.Compact { @@ -45,8 +46,9 @@ func (w *Writer) WriteAnnounce(res *models.AnnounceResponse) error { } func (w *Writer) WriteScrape(res *models.ScrapeResponse) error { - dict := bencode.NewDict() - dict["files"] = filesDict(res.Files) + dict := bencode.Dict{ + "files": filesDict(res.Files), + } bencoder := bencode.NewEncoder(w) return bencoder.Encode(dict)