LBRYFoundation/pool
1
0
Fork 0
mirror of https://github.com/LBRYFoundation/pool.git synced 2025-08-23 17:37:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

stratum: ensure share params are all strings

Browse source
This commit is contained in:
Tanguy Pruvot 2018-06-22 09:25:05 +02:00
parent 609f6126ca
commit ae6af25dec
1 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
stratum/client_submit.cpp
View file

@ -349,11 +349,20 @@ static bool ntime_valid_range(const char ntimehex[])
return (abs(rawtime - ntime) < (30 * 60)); return (abs(rawtime - ntime) < (30 * 60));
} }
static bool valid_string_params(json_value *json_params)
{
bool valid = true;
for(int p=0; p < json_params->u.array.length; p++) {
if (!json_is_string(json_params->u.array.values[p]))
return false;
}
return valid;
}
bool client_submit(YAAMP_CLIENT *client, json_value *json_params) bool client_submit(YAAMP_CLIENT *client, json_value *json_params)
{ {
// submit(worker_name, jobid, extranonce2, ntime, nonce): // submit(worker_name, jobid, extranonce2, ntime, nonce):
if(json_params->u.array.length<5) if(json_params->u.array.length<5 || !valid_string_params(json_params)) {
{
debuglog("%s - %s bad message\n", client->username, client->sock->ip); debuglog("%s - %s bad message\n", client->username, client->sock->ip);
client->submit_bad++; client->submit_bad++;
return false; return false;
@ -365,7 +374,7 @@ bool client_submit(YAAMP_CLIENT *client, json_value *json_params)
char ntime[32] = { 0 }; char ntime[32] = { 0 };
char vote[8] = { 0 }; char vote[8] = { 0 };
if (!json_params->u.array.values[1]->u.string.ptr || strlen(json_params->u.array.values[1]->u.string.ptr) > 32) { if (strlen(json_params->u.array.values[1]->u.string.ptr) > 32) {
clientlog(client, "bad json, wrong jobid len"); clientlog(client, "bad json, wrong jobid len");
client->submit_bad++; client->submit_bad++;
return false; return false;