From ec9825a8563cd824d8483a468ebc2486980f86d8 Mon Sep 17 00:00:00 2001
From: Jeremy Kauffman <jeremy@lbry.io>
Date: Thu, 19 Sep 2019 12:14:15 -0400
Subject: [PATCH] restore pr, adjust notices

---
 controller/action/MailActions.class.php | 52 +++++++------------------
 lib/thirdparty/LBRY.class.php           |  7 ++++
 view/template/layout/basic.php          |  3 +-
 view/template/mail/_settingsForm.php    | 48 +++++++++++++----------
 web/scss/components/_notice.scss        |  3 --
 5 files changed, 49 insertions(+), 64 deletions(-)

diff --git a/controller/action/MailActions.class.php b/controller/action/MailActions.class.php
index 90cebe42..597109b9 100644
--- a/controller/action/MailActions.class.php
+++ b/controller/action/MailActions.class.php
@@ -78,45 +78,19 @@ class MailActions extends Actions
 
     public static function prepareSettingsFormPartial(array $vars)
     {
-        return $vars + [
-        'tagMetadata' => [
-           '3d-printing' => [
-              'label' => '3D Printing',
-              'description' => 'Receive updates, tips, and new content suggestions related to 3D Printing.'
-           ],
-          'android' => [
-            'label' => 'Android',
-            'description' => 'Be an Android beta tester, earn LBC, and receive notification when the app goes live!'
-          ],
-          'college' => [
-            'label' => 'University',
-            'description' => 'LBRY has special programs and opportunities for people in school.'
-          ],
-          'creator' => [
-            'label' => 'Creator',
-            'description' => 'Get the most out of the stuff you create with tips and feedback from LBRY.'
-          ],
-          'consumer' => [
-            'label' => 'Content Lover',
-            'description' => 'Learn how to get the most out of LBRY as someone who just wants to find cool stuff.'
-          ],
-          'developer' => [
-            'label' => 'Developer',
-            'description' => 'Receive technical updates and other news intended for those who are familiar with software engineering.'
-          ],
-          'ios' => [
-            'label' => 'iPhone',
-            'description' => 'Be an iOS alpha tester, earn LBC, and receive notification when the app goes live!'
-          ],
-          'reward' => [
-            'label' => 'Rewards',
-            'description' => 'Receive emails about the latest rewards that are available to LBRY users.'
-          ],
-          'subscription' => [
-            'label' => 'Subscriptions',
-            'description' => 'Stay up to date on the latest content from your favorite creators.'
-          ],
-         ]
+      $tags = LBRY::listTags($vars['token']);
+      $tagMetadata = [];
+      $specialDisplayNames = [
+        'ios' => 'iOS'
       ];
+      foreach($tags as $tag) {
+        if ($tag['is_user_addable']) {
+          $tagMetadata[$tag['name']] = [
+            'label' => $specialDisplayNames[$tag['name']] ?? ucwords(str_replace(['-', '_'], ' ', $tag['name'])),
+            'description' => $tag['description']
+          ];
+        }
+      }
+      return $vars + ['tagMetadata' => $tagMetadata];
     }
 }
diff --git a/lib/thirdparty/LBRY.class.php b/lib/thirdparty/LBRY.class.php
index 9b980d50..4bbd864d 100644
--- a/lib/thirdparty/LBRY.class.php
+++ b/lib/thirdparty/LBRY.class.php
@@ -21,6 +21,13 @@ class LBRY
         return $response['data']['lbc_usd'] ?? 0;
     }
 
+    public static function listTags($authToken)
+    {
+      echo $authToken;
+      $response = Curl::get(static::getApiUrl('/tag/list'), ['auth_token' => $authToken], ['json_response' => true]);
+      return $response['data'] ?? [];
+    }
+
     public static function subscribe($email, $tag = null)
     {
         return Curl::post(static::getApiUrl('/list/subscribe'), array_filter([
diff --git a/view/template/layout/basic.php b/view/template/layout/basic.php
index d7fcb390..a8593d56 100644
--- a/view/template/layout/basic.php
+++ b/view/template/layout/basic.php
@@ -58,7 +58,8 @@
     <meta name="twitter:creator" content="@lbryio"/>
     <meta name="twitter:description" content="<?php echo Response::getMetaDescription() ?>"/>
     <?php if (Response::getMetaImages()): ?>
-        <?php $url = reset(Response::getMetaImages()) ?>
+        <?php $images = Response::getMetaImages() ?>
+        <?php $url = reset($images) ?>
         <meta name="twitter:image" content="<?php echo $url ?>" />
     <?php endif ?>
 
diff --git a/view/template/mail/_settingsForm.php b/view/template/mail/_settingsForm.php
index 0a9f7b0a..e83bd80b 100644
--- a/view/template/mail/_settingsForm.php
+++ b/view/template/mail/_settingsForm.php
@@ -11,49 +11,55 @@
   <div class="notice notice-error spacer1"><?php echo $error ?></div>
 <?php else: ?>
   <form id="<?php echo $formId ?>" novalidate style="display: none">
-    <section class="email-section" style="position: relative;">
+    <section class="email-section">
+        <div style="min-height: 33px"> <?php //hack fix to prevent jumping ?>
+            <div class="notice notice-error hide spacer-half"></div>
+            <div class="notice notice-success hide spacer-half">Your email preferences have been updated.</div>
+        </div>
       <h4><?php echo count($emails) > 1 ? 'Receiving Addresses' : 'Do You Want To Receive Mail?' ?></h4>
       <?php if (count($emails) > 1): ?>
         <div class="meta spacer-half">Uncheck all boxes if you want to receive no future messages.</div>
       <?php endif ?>
 
-      <div class="notice notice-error hide spacer-half"></div>
-      <div class="notice notice-success hide spacer-half">Your email preferences have been updated.</div>
-
       <?php $emailIndex = 0 ?>
 
       <?php foreach ($emails as $email => $enabled): ?>
         <?php $emailId = 'email_' . (++$emailIndex) ?>
         <checkbox-element>
           <input id="<?php echo $emailId ?>" name="<?php echo $emailId ?>" type="checkbox"<?php echo $enabled ? " checked" : "" ?> value="<?php echo urlencode($email) ?>"/>
-          <label for="<?php echo $emailId ?>"><?php echo $email ?></label>
+          <label for="<?php echo $emailId ?>"><?php echo count($emails) > 1 ? $email : __('Yes') . ' (' . $email . ')' ?></label>
           <checkbox-toggle/>
         </checkbox-element>
       <?php endforeach ?>
     </section>
 
-    <section class="tag-section spacer1" style="position: relative;">
+    <section class="tag-section spacer1">
+        <div style="min-height: 33px"> <?php //hack fix to prevent jumping ?>
+            <div class="notice notice-error hide spacer-half"></div>
+            <div class="notice notice-success hide spacer-half">Your email preferences have been updated.</div>
+        </div>
       <h4>Fine-tune your Mail</h4>
-      <div class="notice notice-error hide spacer-half"></div>
-      <div class="notice notice-success hide spacer-half">Your email preferences have been updated.</div>
 
       <?php $tagIndex = 0 ?>
       <?php foreach ($tags as $tag => $enabled): ?>
-        <?php if (!isset($tagMetadata[$tag])) {
-    continue;
-}  //fix/kill this?>
+        <?php if (!isset($tagMetadata[$tag])) continue; ?>
         <?php $tagId = 'tag_' . (++$tagIndex) ?>
-        <checkbox-element>
-          <input id="<?php echo $tagId ?>" name="<?php echo $tagId ?>" type="checkbox"<?php echo $enabled ? " checked" : "" ?> value="<?php echo urlencode($tag) ?>"/>
-          <label for="<?php echo $tagId ?>">
-            <?php echo isset($tagMetadata[$tag]['label']) ? $tagMetadata[$tag]['label'] : $tag ?>
-            <?php if (isset($tagMetadata[$tag]['description'])): ?>
-              <span class="meta">&middot; <?php echo $tagMetadata[$tag]['description'] ?></small>
-            <?php endif ?>
-          </label>
-          <checkbox-toggle/>
-        </checkbox-element>
+        <div>
+          <checkbox-element>
+              <input id="<?php echo $tagId ?>" name="<?php echo $tagId ?>" type="checkbox"<?php echo $enabled ? " checked" : "" ?> value="<?php echo urlencode($tag) ?>"/>
+              <label for="<?php echo $tagId ?>">
+                <?php echo isset($tagMetadata[$tag]['label']) ? $tagMetadata[$tag]['label'] : $tag ?>
+                <?php if (isset($tagMetadata[$tag]['description'])): ?>
+                  <span class="meta">&middot; <?php echo $tagMetadata[$tag]['description'] ?></span>
+                <?php endif ?>
+              </label>
+              <checkbox-toggle/>
+          </checkbox-element>
+        </div>
       <?php endforeach ?>
+      <?php if ($tagIndex === 0): ?>
+          <div class="notice notice-error"><?php echo __('Something went wrong. Please email help@lbry.com') ?></div>
+      <?php endif ?>
     </section>
   </form>
 <?php endif ?>
diff --git a/web/scss/components/_notice.scss b/web/scss/components/_notice.scss
index 97af2fbd..58fd74f1 100644
--- a/web/scss/components/_notice.scss
+++ b/web/scss/components/_notice.scss
@@ -9,13 +9,10 @@
 }
 
 .notice {
-  top: -0.5rem; right: 0;
-
   border: 1px solid var(--lbry-gray-1);
   font-size: 0.8rem;
   // margin-bottom: 0.5rem;
   padding: 0.5rem 0.75rem;
-  position: absolute;
 
   [href] {
     text-decoration: underline;