LBRYFoundation/lbry.com
1
0
Fork 0
mirror of https://github.com/LBRYFoundation/lbry.com.git synced 2025-08-23 17:47:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix github username loophole

Browse source
This commit is contained in:
Alex Grintsvayg 2017-02-03 15:48:46 -05:00
parent d0a9e26912
commit e18384b862
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
controller/action/AcquisitionActions.class.php
View file

@ -105,6 +105,7 @@ class AcquisitionActions extends Actions
'headers' => ['Accept: application/json'], 'headers' => ['Accept: application/json'],
'json_response' => true 'json_response' => true
]); ]);
if (!$authResponseData || !isset($authResponseData['access_token'])) if (!$authResponseData || !isset($authResponseData['access_token']))
{ {
Session::setFlash(Session::KEY_DEVELOPER_CREDITS_ERROR, 'Request to GitHub failed.'); Session::setFlash(Session::KEY_DEVELOPER_CREDITS_ERROR, 'Request to GitHub failed.');
@ -134,7 +135,7 @@ class AcquisitionActions extends Actions
$existing = is_file($dataFile) ? json_decode(file_get_contents($dataFile), true) : []; $existing = is_file($dataFile) ? json_decode(file_get_contents($dataFile), true) : [];
if (isset($existing[$userResponseData['login']])) if (isset($existing[$userResponseData['login']]) || isset($existing[$userResponseData['id']]))
{ {
Session::setFlash(Session::KEY_DEVELOPER_CREDITS_ERROR, 'You already received credits.'); Session::setFlash(Session::KEY_DEVELOPER_CREDITS_ERROR, 'You already received credits.');
} }
@ -151,7 +152,7 @@ class AcquisitionActions extends Actions
if ($response === [true]) if ($response === [true])
{ {
$existing[$userResponseData['login']] = [$userResponseData['email'], $walletAddress, date('Y-m-d H:i:s')]; $existing[$userResponseData['id']] = [$userResponseData['email'], $walletAddress, date('Y-m-d H:i:s'), $userResponseData['login']];
file_put_contents($dataFile, json_encode($existing)); file_put_contents($dataFile, json_encode($existing));
Session::setFlash(Session::KEY_DEVELOPER_CREDITS_SUCCESS, Session::setFlash(Session::KEY_DEVELOPER_CREDITS_SUCCESS,