report 405s correctly

controller/Controller.class.php

@@ -60,6 +60,12 @@ class Controller
     {
       return NavActions::execute404();
     }
+    catch (\Routing\HttpMethodNotAllowedException $e)
+    {
+      Response::setStatus(405);
+      Response::setHeader('Allow', implode(', ', $e->getAllowedMethods()));
+      return ['page/404'];
+    }
   }
 
   protected static function getRouterWithRoutes(): \Routing\RouteCollector

data/i18n/en.yaml

@@ -93,6 +93,7 @@ news:
   next: Next
   prev: Previous
 page:
+  badmethod: HTTP method not allowed
   faq:
     back: Back to FAQ
     header: Frequently Asked Questions

lib/routing/Dispatcher.class.php

@@ -175,7 +175,7 @@ class Dispatcher
 
     $this->matchedRoute = $routes;
 
-    throw new HttpMethodNotAllowedException('Allow: ' . implode(', ', array_keys($routes)));
+    throw new HttpMethodNotAllowedException(array_keys($routes), 'Method not allowed');
   }
 
   /**

lib/routing/HttpMethodNotAllowedException.class.php

@@ -2,4 +2,18 @@
 
 namespace Routing;
 
-class HttpMethodNotAllowedException extends HttpException {}
+class HttpMethodNotAllowedException extends HttpException
+{
+  protected $allowedMethods;
+
+  public function __construct(array $allowedMethods, $message, $code, Exception $previous)
+  {
+    $this->allowedMethods = $allowedMethods;
+    parent::__construct($message, $code, $previous);
+  }
+
+  public function getAllowedMethods()
+  {
+    return $this->allowedMethods;
+  }
+}

view/template/page/405.php

@@ -0,0 +1,7 @@
+<?php echo View::render('nav/_header', ['isDark' => false]) ?>
+<main>
+  <div class="content">
+    <h1>{{page.badmethod}}</h1>
+    <p>{{page.funnier}}</p>
+  </div>
+</main>