From e1130147b542e98082e8316cc3d11415404d4bef Mon Sep 17 00:00:00 2001 From: Victor Shyba Date: Thu, 27 Sep 2018 01:56:04 -0300 Subject: [PATCH] fix format of resolve on inexistent URI --- lbrynet/wallet/resolve.py | 4 +++- tests/integration/wallet/test_transactions.py | 5 +++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/lbrynet/wallet/resolve.py b/lbrynet/wallet/resolve.py index 36587ee5c..7da7d52d2 100644 --- a/lbrynet/wallet/resolve.py +++ b/lbrynet/wallet/resolve.py @@ -36,7 +36,9 @@ class Resolver: (yield self._handle_resolve_uri_response(uri, resolution, page, page_size)) ) except (UnknownNameError, UnknownClaimID, UnknownURI) as err: - results[uri] = {'error': err.message} + results[uri] = {'error': str(err)} + else: + results[uri] = {'error': "URI lbry://{} cannot be resolved".format(uri.replace("lbry://", ""))} defer.returnValue(results) @defer.inlineCallbacks diff --git a/tests/integration/wallet/test_transactions.py b/tests/integration/wallet/test_transactions.py index 231e3ee75..f1d08b774 100644 --- a/tests/integration/wallet/test_transactions.py +++ b/tests/integration/wallet/test_transactions.py @@ -89,3 +89,8 @@ class BasicTransactionTest(IntegrationTestCase): response = await d2f(self.ledger.resolve(0, 10, 'lbry://@bar/foo')) self.assertNotIn('claim', response['lbry://@bar/foo']) + + # checks for expected format in inexistent URIs + response = await d2f(self.ledger.resolve(0, 10, 'lbry://404', 'lbry://@404')) + self.assertEqual('URI lbry://404 cannot be resolved', response['lbry://404']['error']) + self.assertEqual('URI lbry://@404 cannot be resolved', response['lbry://@404']['error'])