From 468a16af584aa7e393cd0bd63a028c92fe6bda07 Mon Sep 17 00:00:00 2001 From: Kay Kurokawa Date: Wed, 13 Sep 2017 13:04:05 -0400 Subject: [PATCH] move check for write_handle to the beginning and raise exception when writing to a closed file handle --- lbrynet/core/HashBlob.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lbrynet/core/HashBlob.py b/lbrynet/core/HashBlob.py index 452e4ce7a..49258ba89 100644 --- a/lbrynet/core/HashBlob.py +++ b/lbrynet/core/HashBlob.py @@ -55,6 +55,10 @@ class HashBlobWriter(object): return self._hashsum.hexdigest() def write(self, data): + if self.write_handle is None: + log.info("writer has already been closed") + raise ValueError('I/O operation on closed file') + self._hashsum.update(data) self.len_so_far += len(data) if self.len_so_far > self.length_getter(): @@ -64,9 +68,6 @@ class HashBlobWriter(object): " %s to %s" % (self.len_so_far, self.length_getter())))) else: - if self.write_handle is None: - log.debug("Tried to write to a write_handle that was None.") - return self.write_handle.write(data) if self.len_so_far == self.length_getter(): self.finished_cb(self)