mirror of
https://github.com/LBRYFoundation/lbry-sdk.git
synced 2025-09-01 17:55:13 +00:00
Merge pull request #453 from lbryio/add-details-to-error-event
Add details to error event
This commit is contained in:
commit
2c137a99d1
4 changed files with 11 additions and 9 deletions
|
@ -60,10 +60,13 @@ class Events(object):
|
||||||
properties = download_properties(*args, **kwargs)
|
properties = download_properties(*args, **kwargs)
|
||||||
return self._event('Download Finished', properties)
|
return self._event('Download Finished', properties)
|
||||||
|
|
||||||
def error(self, message, sd_hash=None):
|
def error(self, log_record):
|
||||||
|
"""Record when a log message of ERROR or higher was emitted"""
|
||||||
properties = {
|
properties = {
|
||||||
'message': message,
|
'message': log_record.message,
|
||||||
'stream_info': sd_hash
|
'module': log_record.module,
|
||||||
|
'lineno': log_record.lineno,
|
||||||
|
'name': log_record.name,
|
||||||
}
|
}
|
||||||
return self._event('Error', properties)
|
return self._event('Error', properties)
|
||||||
|
|
||||||
|
|
|
@ -8,4 +8,4 @@ class Handler(logging.Handler):
|
||||||
logging.Handler.__init__(self, level)
|
logging.Handler.__init__(self, level)
|
||||||
|
|
||||||
def emit(self, record):
|
def emit(self, record):
|
||||||
self.manager.send_error(record.message)
|
self.manager.send_error(record)
|
||||||
|
|
|
@ -82,8 +82,8 @@ class Manager(object):
|
||||||
event = self.events_generator.download_finished(id_, name, stream_info)
|
event = self.events_generator.download_finished(id_, name, stream_info)
|
||||||
self.analytics_api.track(event)
|
self.analytics_api.track(event)
|
||||||
|
|
||||||
def send_error(self, message, sd_hash=None):
|
def send_error(self, message):
|
||||||
event = self.events_generator.error(message, sd_hash)
|
event = self.events_generator.error(message)
|
||||||
self.analytics_api.track(event)
|
self.analytics_api.track(event)
|
||||||
|
|
||||||
def register_repeating_metric(self, event_name, value_generator, frequency=300):
|
def register_repeating_metric(self, event_name, value_generator, frequency=300):
|
||||||
|
|
|
@ -761,14 +761,13 @@ class Daemon(AuthJSONRPCServer):
|
||||||
|
|
||||||
def eb():
|
def eb():
|
||||||
if not r.called:
|
if not r.called:
|
||||||
self.analytics_manager.send_error("sd blob download timed out", sd_hash)
|
log.error("sd blob download timed out: %s", sd_hash)
|
||||||
r.errback(Exception("sd timeout"))
|
r.errback(Exception("sd timeout"))
|
||||||
|
|
||||||
r = defer.Deferred(None)
|
r = defer.Deferred(None)
|
||||||
reactor.callLater(timeout, eb)
|
reactor.callLater(timeout, eb)
|
||||||
d = download_sd_blob(self.session, sd_hash, self.session.payment_rate_manager)
|
d = download_sd_blob(self.session, sd_hash, self.session.payment_rate_manager)
|
||||||
d.addErrback(lambda err: self.analytics_manager.send_error(
|
d.addErrback(log.fail(), "Error downloading sd blob: %s", sd_hash)
|
||||||
"error downloading sd blob: " + err, sd_hash))
|
|
||||||
d.addCallback(BlobStreamDescriptorReader)
|
d.addCallback(BlobStreamDescriptorReader)
|
||||||
d.addCallback(lambda blob: blob.get_info())
|
d.addCallback(lambda blob: blob.get_info())
|
||||||
d.addCallback(cb)
|
d.addCallback(cb)
|
||||||
|
|
Loading…
Add table
Reference in a new issue