diff --git a/CHANGELOG.md b/CHANGELOG.md index 8972e8ed1..0ff63a301 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -20,6 +20,7 @@ at anytime. * edge cases of http mirrored download of blobs * ports with upnp redirects not showing the correct external port in log messages ( https://github.com/lbryio/lbry/issues/1338 ) * miniupnpc fallback issue in txupnp ( https://github.com/lbryio/lbry/issues/1341 ) + * upnp error when disabled on router and a non-gateway is found, such as chromecast ( https://github.com/lbryio/lbry/issues/1352 ) ### Deprecated * automatic claim renew, this is no longer needed diff --git a/lbrynet/daemon/Components.py b/lbrynet/daemon/Components.py index e65ca0e40..053240986 100644 --- a/lbrynet/daemon/Components.py +++ b/lbrynet/daemon/Components.py @@ -683,8 +683,12 @@ class UPnPComponent(Component): elif found and self.upnp.miniupnpc_runner: log.warning("failed to set up redirect with txupnp, miniupnpc fallback was successful") if found: - self.external_ip = yield self.upnp.get_external_ip() - yield self._setup_redirects() + try: + self.external_ip = yield self.upnp.get_external_ip() + yield self._setup_redirects() + except Exception as err: + log.warning("error trying to set up upnp: %s", err) + self.external_ip = CS.get_external_ip() else: self.external_ip = CS.get_external_ip()