mirror of
https://github.com/LBRYFoundation/lbry-desktop.git
synced 2025-08-30 08:51:24 +00:00
032e17cecd
## Issue 6068 Fix "Cumulative Layout Shift" for Core Web Vitals In Posts, the Comments section appears first while we fetch the MD file. When the MD is fetched, Comments get pushed to the bottom (or shifted up for short posts), hence the red CLS scores. ## Approach There are too many layers between `<FilePage>` and `<DocumentViewer>` to pass the `loading` state around to hide the Comments section, so just make Comments fade in after a 2s delay. ## Changes - Posts: Add 2s fade-in delay to Comments. - Posts: remove the gray placeholder. This improves the score a bit more, and reduces flicker as well. There's already a spinner from `FileRenderInline` to tell the user to be patient. - Posts: add a minimum 30vh height so that short posts don't get collapsed too much, causing the `FileDetails` and Comments to shift. Small shifts are fine as long as CLS is below 0.1. |
||
|---|---|---|
| .. | ||
| component | ||
| constants | ||
| effects | ||
| modal | ||
| page | ||
| redux | ||
| scss | ||
| util | ||
| analytics.js | ||
| app.js | ||
| comments.js | ||
| i18n.js | ||
| index.jsx | ||
| logWarningConsoleMessage.js | ||
| native.js | ||
| reducers.js | ||
| rewards.js | ||
| store.js | ||