From fc79c87bba9ec42ae93bdfb99ed17bd36445c0fa Mon Sep 17 00:00:00 2001
From: infiinte-persistence <inf.persistence@gmail.com>
Date: Tue, 10 Nov 2020 04:32:50 +0800
Subject: [PATCH] Fix sidebar tooltip showing string with context metadata.

## Issue
In the odysee branch, the tooltip for "Following" in the Sidebar was shown as "Following --[sidebar]--". In lbry.tv, the tooltip doesn't appear.

I believe the tooltip appeared due to the name change from 'label' to 'title' and then being passed to Button through '...passedProps'.

Fix by explicitly setting the Button's 'title' to the localized text.
---
 ui/component/sideNavigation/view.jsx | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/ui/component/sideNavigation/view.jsx b/ui/component/sideNavigation/view.jsx
index 7480b6e9a..660680a5a 100644
--- a/ui/component/sideNavigation/view.jsx
+++ b/ui/component/sideNavigation/view.jsx
@@ -336,6 +336,7 @@ function SideNavigation(props: Props) {
                     <Button
                       {...passedProps}
                       label={__(linkProps.title)}
+                      title={__(linkProps.title)}
                       //   $FlowFixMe
                       navigate={linkProps.route || linkProps.link}
                       icon={pulseLibrary && linkProps.icon === ICONS.LIBRARY ? ICONS.PURCHASED : linkProps.icon}
@@ -415,6 +416,7 @@ function SideNavigation(props: Props) {
                         {...passedProps}
                         navigate={route || link}
                         label={__(linkProps.title)}
+                        title={__(linkProps.title)}
                         icon={pulseLibrary && linkProps.icon === ICONS.LIBRARY ? ICONS.PURCHASED : linkProps.icon}
                         className={classnames('navigation-link', {
                           'navigation-link--pulse': linkProps.icon === ICONS.LIBRARY && pulseLibrary,
@@ -437,6 +439,7 @@ function SideNavigation(props: Props) {
                         {...passedProps}
                         navigate={linkProps.link}
                         label={__(linkProps.title)}
+                        title={__(linkProps.title)}
                         className="navigation-link"
                         activeClass="navigation-link--active"
                       />