From 536c5391fb1766b844cd5b2d75d715126e78a3fb Mon Sep 17 00:00:00 2001
From: Alex Liebowitz <alex@alexliebowitz.com>
Date: Fri, 5 May 2017 00:38:13 -0400
Subject: [PATCH] Make error modals display full screen properly

Was not passing in the generic modal-overlay class. (ExpandableModal
doesn't provide it automatically so you can omit it and make a totally
custom overlay if you want.)
---
 CHANGELOG.md             | 2 +-
 ui/js/app.js             | 2 +-
 ui/js/component/modal.js | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 7b6aa8859..e5c7dcda9 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -16,7 +16,7 @@ Web UI version numbers should always match the corresponding version of LBRY App
   *
 
 ### Fixed
-  *
+  * Error modals now display full screen properly
   *
 
 ### Deprecated
diff --git a/ui/js/app.js b/ui/js/app.js
index 85f8891a6..bdef281a0 100644
--- a/ui/js/app.js
+++ b/ui/js/app.js
@@ -303,7 +303,7 @@ var App = React.createClass({
             </div>
           </Modal>
           <ExpandableModal isOpen={this.state.modal == 'error'} contentLabel="Error" className="error-modal"
-                           overlayClassName="error-modal-overlay" onConfirmed={this.closeModal}
+                           overlayClassName="modal-overlay error-modal-overlay" onConfirmed={this.closeModal}
                            extraContent={this.state.errorInfo}>
             <h3 className="modal__header">Error</h3>
 
diff --git a/ui/js/component/modal.js b/ui/js/component/modal.js
index dbb8ff646..27250a8a3 100644
--- a/ui/js/component/modal.js
+++ b/ui/js/component/modal.js
@@ -28,7 +28,7 @@ export const Modal = React.createClass({
     return (
       <ReactModal onCloseRequested={this.props.onAborted || this.props.onConfirmed} {...this.props}
                   className={(this.props.className || '') + ' modal'}
-                  overlayClassName={[null, undefined, ""].indexOf(this.props.overlayClassName) === -1 ? this.props.overlayClassName : 'modal-overlay'}>
+                  overlayClassName={![null, undefined, ""].includes(this.props.overlayClassName) ? this.props.overlayClassName : 'modal-overlay'}>
         <div>
           {this.props.children}
         </div>