From d01c20394ec823c0c581ace3056331d2ba8b384a Mon Sep 17 00:00:00 2001 From: infiinte-persistence Date: Thu, 11 Jun 2020 20:55:30 +0200 Subject: [PATCH] Fix "muted=false + volume=0" case. We need to handle two types of "mute": - Volume icon is pressed to mute. - Volume slider moved to 0%. --- ui/component/viewers/videoViewer/internal/videojs.jsx | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ui/component/viewers/videoViewer/internal/videojs.jsx b/ui/component/viewers/videoViewer/internal/videojs.jsx index bcdc390c1..407c164b8 100644 --- a/ui/component/viewers/videoViewer/internal/videojs.jsx +++ b/ui/component/viewers/videoViewer/internal/videojs.jsx @@ -114,12 +114,15 @@ export default React.memo(function VideoJs(props: Props) { function unmuteAndHideHint() { if (player) { player.muted(false); + if (player.volume() === 0) { + player.volume(1.0); + } } showTapToUnmute(false); } function onInitialPlay() { - if (player && player.muted()) { + if (player && (player.muted() || player.volume() === 0)) { // The css starts as "hidden". We make it visible here without // re-rendering the whole thing. showTapToUnmute(true);