From c11b73d117a75c0f1e7bea69b32c59560958c69f Mon Sep 17 00:00:00 2001
From: btzr-io <btzr.io@gmail.com>
Date: Tue, 13 Jul 2021 16:23:29 -0500
Subject: [PATCH] use aria-hidden for icons indside buttons

use aria-expanded for sidebar menu button
---
 ui/component/button/view.jsx | 4 ++--
 ui/component/header/view.jsx | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/ui/component/button/view.jsx b/ui/component/button/view.jsx
index dc0a18030..736f5dfea 100644
--- a/ui/component/button/view.jsx
+++ b/ui/component/button/view.jsx
@@ -102,7 +102,7 @@ const Button = forwardRef<any, {}>((props: Props, ref: any) => {
 
   const content = (
     <span className="button__content">
-      {icon && <Icon icon={icon} iconColor={iconColor} size={iconSize} />}
+      {icon && <Icon aria-hidden icon={icon} iconColor={iconColor} size={iconSize} />}
 
       {!largestLabel && label && (
         <span dir="auto" className="button__label">
@@ -139,7 +139,7 @@ const Button = forwardRef<any, {}>((props: Props, ref: any) => {
       )}
 
       {children && children}
-      {iconRight && <Icon icon={iconRight} iconColor={iconColor} size={size} />}
+      {iconRight && <Icon aria-hidden icon={iconRight} iconColor={iconColor} size={size} />}
     </span>
   );
 
diff --git a/ui/component/header/view.jsx b/ui/component/header/view.jsx
index cf1cea516..8d127823a 100644
--- a/ui/component/header/view.jsx
+++ b/ui/component/header/view.jsx
@@ -244,6 +244,7 @@ const Header = (props: Props) => {
                     }
                     className="header__navigation-item menu__title header__navigation-item--icon"
                     icon={ICONS.MENU}
+                    aria-expanded={sidebarOpen}
                     onClick={() => setSidebarOpen(!sidebarOpen)}
                   >
                     {isAbsoluteSideNavHidden && isMobile && notificationsEnabled && <NotificationBubble />}