From aa04d1256f0042ee18a9ba6f6688deab94317c6a Mon Sep 17 00:00:00 2001 From: btzr-io Date: Tue, 4 Jun 2019 22:11:24 -0600 Subject: [PATCH] minor fixes for web --- src/ui/component/fileViewer/internal/player.jsx | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/ui/component/fileViewer/internal/player.jsx b/src/ui/component/fileViewer/internal/player.jsx index 198bcc996..75a43dd3c 100644 --- a/src/ui/component/fileViewer/internal/player.jsx +++ b/src/ui/component/fileViewer/internal/player.jsx @@ -115,7 +115,9 @@ class MediaPlayer extends React.PureComponent { this.toggleFullscreen(); } // Handle toggle play + // @if TARGET='app' this.togglePlay(event); + // @endif } }; @@ -130,19 +132,20 @@ class MediaPlayer extends React.PureComponent { toggleFullscreen = () => { const { viewerContainer } = this.props; const isFullscreen = fullscreenElement(); + const isSupportedFile = this.isSupportedFile(); const isPlayableType = this.playableType(); if (!isFullscreen) { // Enter fullscreen mode if content is not playable // Otherwise it should be handle internally on the video player // or it will break the toggle fullscreen button - if (!isPlayableType && viewerContainer && viewerContainer.current !== null) { + if (!isPlayableType && isSupportedFile && viewerContainer && viewerContainer.current !== null) { requestFullscreen(viewerContainer.current); } // Request fullscreen mode for the media player (renderMedia) // Don't use this with the new player // @if TARGET='app' - else { + else if (isPlayableType) { const mediaContainer = this.mediaContainer.current; const mediaElement = mediaContainer && mediaContainer.children[0]; if (mediaElement) { @@ -209,8 +212,6 @@ class MediaPlayer extends React.PureComponent { ); } - document.addEventListener('keydown', this.handleKeyDown); - const mediaElement = container.children[0]; if (mediaElement) { if (position) { @@ -244,6 +245,9 @@ class MediaPlayer extends React.PureComponent { this.renderFile(); } // @endif + + // Fullscreen event for web and app + document.addEventListener('keydown', this.handleKeyDown); } // @if TARGET='app'