From a13708f4dd4b59bb0b66b1bbee209ba4a34a9e43 Mon Sep 17 00:00:00 2001
From: infinite-persistence <inf.persistence@gmail.com>
Date: Thu, 15 Jul 2021 23:31:42 +0800
Subject: [PATCH] Handle the case of all replies are blocked.

In this scenario, `comment.List` does not return `comment`. I was expecting an empty array.

Handled accordingly.
---
 ui/component/commentsReplies/view.jsx | 45 ++++++++++++++-------------
 ui/redux/reducers/comments.js         | 40 ++++++------------------
 2 files changed, 33 insertions(+), 52 deletions(-)

diff --git a/ui/component/commentsReplies/view.jsx b/ui/component/commentsReplies/view.jsx
index 57d19055b..c30d86121 100644
--- a/ui/component/commentsReplies/view.jsx
+++ b/ui/component/commentsReplies/view.jsx
@@ -72,33 +72,34 @@ function CommentsReplies(props: Props) {
             />
           </div>
         )}
-        {fetchedReplies && displayedComments && isExpanded && (
+        {isExpanded && (
           <div>
             <div className="comment__replies">
               <Button className="comment__threadline" aria-label="Hide Replies" onClick={() => setExpanded(false)} />
 
               <ul className="comments--replies">
-                {displayedComments.map((comment) => {
-                  return (
-                    <Comment
-                      threadDepth={threadDepth}
-                      uri={uri}
-                      authorUri={comment.channel_url}
-                      author={comment.channel_name}
-                      claimId={comment.claim_id}
-                      commentId={comment.comment_id}
-                      key={comment.comment_id}
-                      message={comment.comment}
-                      timePosted={comment.timestamp * 1000}
-                      claimIsMine={claimIsMine}
-                      commentIsMine={comment.channel_id && isMyComment(comment.channel_id)}
-                      linkedCommentId={linkedCommentId}
-                      commentingEnabled={commentingEnabled}
-                      supportAmount={comment.support_amount}
-                      numDirectReplies={comment.replies}
-                    />
-                  );
-                })}
+                {displayedComments &&
+                  displayedComments.map((comment) => {
+                    return (
+                      <Comment
+                        threadDepth={threadDepth}
+                        uri={uri}
+                        authorUri={comment.channel_url}
+                        author={comment.channel_name}
+                        claimId={comment.claim_id}
+                        commentId={comment.comment_id}
+                        key={comment.comment_id}
+                        message={comment.comment}
+                        timePosted={comment.timestamp * 1000}
+                        claimIsMine={claimIsMine}
+                        commentIsMine={comment.channel_id && isMyComment(comment.channel_id)}
+                        linkedCommentId={linkedCommentId}
+                        commentingEnabled={commentingEnabled}
+                        supportAmount={comment.support_amount}
+                        numDirectReplies={comment.replies}
+                      />
+                    );
+                  })}
                 {totalReplies < numDirectReplies && (
                   <li className="comment comment--reply">
                     <div className="comment__content">
diff --git a/ui/redux/reducers/comments.js b/ui/redux/reducers/comments.js
index 171d520eb..5065fa9bd 100644
--- a/ui/redux/reducers/comments.js
+++ b/ui/redux/reducers/comments.js
@@ -4,8 +4,6 @@ import { handleActions } from 'util/redux-utils';
 import { BLOCK_LEVEL } from 'constants/comment';
 import { isURIEqual } from 'lbry-redux';
 
-const IS_DEV = process.env.NODE_ENV !== 'production';
-
 const defaultState: CommentsState = {
   commentById: {}, // commentId -> Comment
   byId: {}, // ClaimID -> list of fetched comment IDs.
@@ -277,6 +275,15 @@ export default handleActions(
       const totalRepliesByParentId = Object.assign({}, state.totalRepliesByParentId);
       const isLoadingByParentId = Object.assign({}, state.isLoadingByParentId);
 
+      if (!parentId) {
+        totalCommentsById[claimId] = totalItems;
+        topLevelTotalCommentsById[claimId] = totalFilteredItems;
+        topLevelTotalPagesById[claimId] = totalPages;
+      } else {
+        totalRepliesByParentId[parentId] = totalFilteredItems;
+        isLoadingByParentId[parentId] = false;
+      }
+
       const commonUpdateAction = (comment, commentById, commentIds, index) => {
         // map the comment_ids to the new comments
         commentById[comment.comment_id] = comment;
@@ -289,46 +296,19 @@ export default handleActions(
         // sort comments by their timestamp
         const commentIds = Array(comments.length);
 
-        // totalCommentsById[claimId] = totalItems;
-        // --> currently, this value is only correct when done via a top-level query.
-        // Until this is fixed, I'm moving it downwards to **
-
         // --- Top-level comments ---
         if (!parentId) {
-          totalCommentsById[claimId] = totalItems; // **
-
-          topLevelTotalCommentsById[claimId] = totalFilteredItems;
-          topLevelTotalPagesById[claimId] = totalPages;
-
-          if (!topLevelCommentsById[claimId]) {
-            topLevelCommentsById[claimId] = [];
-          }
-
-          const topLevelCommentIds = topLevelCommentsById[claimId];
-
           for (let i = 0; i < comments.length; ++i) {
             const comment = comments[i];
             commonUpdateAction(comment, commentById, commentIds, i);
-
-            if (IS_DEV && comment['parent_id']) console.error('Invalid top-level comment:', comment); // eslint-disable-line
-
-            if (!topLevelCommentIds.includes(comment.comment_id)) {
-              topLevelCommentIds.push(comment.comment_id);
-            }
+            pushToArrayInObject(topLevelCommentsById, claimId, comment.comment_id);
           }
         }
         // --- Replies ---
         else {
-          totalRepliesByParentId[parentId] = totalFilteredItems;
-          isLoadingByParentId[parentId] = false;
-
           for (let i = 0; i < comments.length; ++i) {
             const comment = comments[i];
             commonUpdateAction(comment, commentById, commentIds, i);
-
-            if (IS_DEV && !comment['parent_id']) console.error('Missing parent_id:', comment); // eslint-disable-line
-            if (IS_DEV && comment.parent_id !== parentId) console.error('Black sheep in the family?:', comment); // eslint-disable-line
-
             pushToArrayInObject(repliesByParentId, parentId, comment.comment_id);
           }
         }