From 21af8f4f2809563414ce69167e447968335d8c42 Mon Sep 17 00:00:00 2001
From: Tobias Speicher <rootcommander@gmail.com>
Date: Tue, 22 Mar 2022 08:38:46 +0100
Subject: [PATCH] refactor: replace deprecated String.prototype.substr()

.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated

Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
---
 electron/createWindow.js                           | 2 +-
 ui/component/common/form-components/form-field.jsx | 2 +-
 ui/component/common/transaction-link.jsx           | 2 +-
 ui/component/dateTime/view.jsx                     | 2 +-
 ui/component/markdownLink/view.jsx                 | 2 +-
 ui/component/publishFile/view.jsx                  | 2 +-
 ui/component/tagsSearch/view.jsx                   | 2 +-
 ui/redux/actions/wallet.js                         | 2 +-
 ui/util/enhanced-layout.js                         | 2 +-
 ui/util/formatMediaDuration.js                     | 4 ++--
 10 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/electron/createWindow.js b/electron/createWindow.js
index 2d24199e1..9b442cce7 100644
--- a/electron/createWindow.js
+++ b/electron/createWindow.js
@@ -95,7 +95,7 @@ export default appState => {
 
   // is it a lbry://? pointing to an app page
   if (deepLinkingURI.includes(lbryProtoQ)) {
-    let path = deepLinkingURI.substr(lbryProtoQ.length);
+    let path = deepLinkingURI.slice(lbryProtoQ.length);
     let page = path.indexOf('?') >= 0 ? path.substring(0, path.indexOf('?')) : path;
     if (Object.values(PAGES).includes(page)) {
       deepLinkingURI = deepLinkingURI.replace(lbryProtoQ, '#/$/');
diff --git a/ui/component/common/form-components/form-field.jsx b/ui/component/common/form-components/form-field.jsx
index 9dac1df87..ebcf4e718 100644
--- a/ui/component/common/form-components/form-field.jsx
+++ b/ui/component/common/form-components/form-field.jsx
@@ -157,7 +157,7 @@ export class FormField extends React.PureComponent<Props> {
 
                 delta = instance.getValue().length + delta - textAreaMaxLength;
                 if (delta > 0) {
-                  str = str.substr(0, str.length - delta);
+                  str = str.substring(0, str.length - delta);
                   changes.update(changes.from, changes.to, str.split('\n'));
                 }
               }
diff --git a/ui/component/common/transaction-link.jsx b/ui/component/common/transaction-link.jsx
index 214ce595c..fca68ef1b 100644
--- a/ui/component/common/transaction-link.jsx
+++ b/ui/component/common/transaction-link.jsx
@@ -10,7 +10,7 @@ const TransactionLink = (props: Props) => {
   const { id } = props;
 
   const href = `https://explorer.lbry.com/tx/${id}`;
-  const label = id.substr(0, 7);
+  const label = id.slice(0, 7);
 
   return <Button button="link" href={href} label={label} />;
 };
diff --git a/ui/component/dateTime/view.jsx b/ui/component/dateTime/view.jsx
index b8e25210f..de4d73d03 100644
--- a/ui/component/dateTime/view.jsx
+++ b/ui/component/dateTime/view.jsx
@@ -49,7 +49,7 @@ class DateTime extends React.Component<Props, State> {
 
     // Strip off the 's' for the singular suffix, construct the string ID,
     // then load the localized version.
-    const suffix = duration === 1 ? suffixList[i].substr(0, suffixList[i].length - 1) : suffixList[i];
+    const suffix = duration === 1 ? suffixList[i].slice(0, -1) : suffixList[i];
     let strId = '%duration% ' + suffix + ' ago';
 
     if (!suffix) {
diff --git a/ui/component/markdownLink/view.jsx b/ui/component/markdownLink/view.jsx
index d2d7ab6fd..f919ea807 100644
--- a/ui/component/markdownLink/view.jsx
+++ b/ui/component/markdownLink/view.jsx
@@ -90,7 +90,7 @@ function MarkdownLink(props: Props) {
         className="button--external-link"
         onClick={() => {
           if (window.player) {
-            window.player.currentTime(parseInt(href.substr(3)));
+            window.player.currentTime(parseInt(href.slice(3)));
             window.scrollTo(0, 0);
           }
         }}
diff --git a/ui/component/publishFile/view.jsx b/ui/component/publishFile/view.jsx
index 38f082632..cc57aca89 100644
--- a/ui/component/publishFile/view.jsx
+++ b/ui/component/publishFile/view.jsx
@@ -276,7 +276,7 @@ function PublishFile(props: Props) {
       filePath: file.path || file,
     };
     // Strip off extention and replace invalid characters
-    let fileName = name || (file.name && file.name.substr(0, file.name.lastIndexOf('.'))) || '';
+    let fileName = name || (file.name && file.name.substring(0, file.name.lastIndexOf('.'))) || '';
 
     if (!isStillEditing) {
       publishFormParams.name = parseName(fileName);
diff --git a/ui/component/tagsSearch/view.jsx b/ui/component/tagsSearch/view.jsx
index 0f9919f34..8a5d6e5fb 100644
--- a/ui/component/tagsSearch/view.jsx
+++ b/ui/component/tagsSearch/view.jsx
@@ -65,7 +65,7 @@ export default function TagsSearch(props: Props) {
   } = props;
   const [newTag, setNewTag] = useState('');
   const doesTagMatch = (name) => {
-    const nextTag = newTag.substr(newTag.lastIndexOf(',') + 1, newTag.length).trim();
+    const nextTag = newTag.slice(newTag.lastIndexOf(',') + 1, newTag.length).trim();
     return newTag ? name.toLowerCase().includes(nextTag.toLowerCase()) : true;
   };
 
diff --git a/ui/redux/actions/wallet.js b/ui/redux/actions/wallet.js
index d0012f531..250eb1182 100644
--- a/ui/redux/actions/wallet.js
+++ b/ui/redux/actions/wallet.js
@@ -80,7 +80,7 @@ export function doFetchTransactions(page = 1, pageSize = 999999) {
 
 export function doFetchTxoPage() {
   return (dispatch, getState) => {
-    const fetchId = Math.random().toString(36).substr(2, 9);
+    const fetchId = Math.random().toString(36).slice(2, 11);
 
     dispatch({
       type: ACTIONS.FETCH_TXO_PAGE_STARTED,
diff --git a/ui/util/enhanced-layout.js b/ui/util/enhanced-layout.js
index 9175f4351..bf0b2efa9 100644
--- a/ui/util/enhanced-layout.js
+++ b/ui/util/enhanced-layout.js
@@ -55,7 +55,7 @@ var Konami = function(callback) {
       konami.input += e ? e.keyCode : event.keyCode;
 
       if (konami.input.length > konami.pattern.length) {
-        konami.input = konami.input.substr(konami.input.length - konami.pattern.length);
+        konami.input = konami.input.slice(konami.input.length - konami.pattern.length);
       }
       if (konami.input === konami.pattern) {
         konami.code(konami._currentLink);
diff --git a/ui/util/formatMediaDuration.js b/ui/util/formatMediaDuration.js
index dc3f1f24b..ec58c704c 100644
--- a/ui/util/formatMediaDuration.js
+++ b/ui/util/formatMediaDuration.js
@@ -15,9 +15,9 @@ export default function formatMediaDuration(duration = 0, config) {
   let date = new Date(null);
   date.setSeconds(duration);
 
-  let timeString = date.toISOString().substr(11, 8);
+  let timeString = date.toISOString().slice(11, 19);
   if (timeString.startsWith('00:')) {
-    timeString = timeString.substr(3);
+    timeString = timeString.slice(3);
   }
 
   return timeString;