LBRYFoundation/lbcwallet
1
0
Fork 0
mirror of https://github.com/LBRYFoundation/lbcwallet.git synced 2025-08-31 17:31:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Modify goclean.sh to run go vet recursively.

Browse source 
Fix remaining issues discovered by vet.
This commit is contained in:
Josh Rickmar 2016-04-19 17:00:53 -04:00
parent 86420c4890
commit f827743934
3 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
cmd/sweepaccount/main.go
View file

@ -55,7 +55,7 @@ var opts = struct {
RPCConnect: "localhost", RPCConnect: "localhost",
RPCUsername: "", RPCUsername: "",
RPCCertificateFile: filepath.Join(walletDataDirectory, "rpc.cert"), RPCCertificateFile: filepath.Join(walletDataDirectory, "rpc.cert"),
FeeRate: &cfgutil.AmountFlag{txrules.DefaultRelayFeePerKb}, FeeRate: cfgutil.NewAmountFlag(txrules.DefaultRelayFeePerKb),
SourceAccount: "imported", SourceAccount: "imported",
DestinationAccount: "default", DestinationAccount: "default",
RequiredConfirmations: 1, RequiredConfirmations: 1,
@ -337,7 +337,7 @@ func parseOutPoint(input *btcjson.ListUnspentResult) (wire.OutPoint, error) {
if err != nil { if err != nil {
return wire.OutPoint{}, err return wire.OutPoint{}, err
} }
return wire.OutPoint{*txHash, input.Vout}, nil return wire.OutPoint{Hash: *txHash, Index: input.Vout}, nil
} }
func pickNoun(n int, singularForm, pluralForm string) string { func pickNoun(n int, singularForm, pluralForm string) string {

2
goclean.sh
View file

@ -13,7 +13,7 @@ set -ex
test -z "$(gofmt -l -w . | tee /dev/stderr)" test -z "$(gofmt -l -w . | tee /dev/stderr)"
test -z "$(goimports -l -w . | tee /dev/stderr)" test -z "$(goimports -l -w . | tee /dev/stderr)"
test -z "$(golint ./... | grep -v 'ALL_CAPS\|OP_\|NewFieldVal\|RpcCommand\|RpcRawCommand\|RpcSend\|Dns\|api.pb.go\|StartConsensusRpc\|factory_test.go\|legacy' | tee /dev/stderr)" test -z "$(golint ./... | grep -v 'ALL_CAPS\|OP_\|NewFieldVal\|RpcCommand\|RpcRawCommand\|RpcSend\|Dns\|api.pb.go\|StartConsensusRpc\|factory_test.go\|legacy' | tee /dev/stderr)"
test -z "$(go tool vet . 2>&1 | grep -v 'Example\|newestSha\|rpcserver/server.go' | tee /dev/stderr)" test -z "$(go vet ./... 2>&1 | grep -v 'Example\|newestSha\|rpcserver/server.go' | tee /dev/stderr)"
env GORACE="halt_on_error=1" go test -v -race ./... env GORACE="halt_on_error=1" go test -v -race ./...
# Run test coverage on each subdirectories and merge the coverage profile. # Run test coverage on each subdirectories and merge the coverage profile.

5
internal/cfgutil/amount.go
View file

@ -17,6 +17,11 @@ type AmountFlag struct {
btcutil.Amount btcutil.Amount
} }
// NewAmountFlag creates an AmountFlag with a default btcutil.Amount.
func NewAmountFlag(defaultValue btcutil.Amount) *AmountFlag {
return &AmountFlag{defaultValue}
}
// MarshalFlag satisifes the flags.Marshaler interface. // MarshalFlag satisifes the flags.Marshaler interface.
func (a *AmountFlag) MarshalFlag() (string, error) { func (a *AmountFlag) MarshalFlag() (string, error) {
return a.Amount.String(), nil return a.Amount.String(), nil