diff --git a/wallet/wallet.go b/wallet/wallet.go index db1277b..5baaddf 100644 --- a/wallet/wallet.go +++ b/wallet/wallet.go @@ -189,8 +189,7 @@ func pad(size int, b []byte) []byte { // ChainedPrivKey deterministically generates a new private key using a // previous address and chaincode. privkey and chaincode must be 32 -// bytes long, and pubkey may either be 33 bytes, 65 bytes or nil (in -// which case it is generated by the privkey). +// bytes long, and pubkey may either be 33 or 65 bytes. func ChainedPrivKey(privkey, pubkey, chaincode []byte) ([]byte, error) { if len(privkey) != 32 { return nil, fmt.Errorf("invalid privkey length %d (must be 32)", @@ -200,9 +199,7 @@ func ChainedPrivKey(privkey, pubkey, chaincode []byte) ([]byte, error) { return nil, fmt.Errorf("invalid chaincode length %d (must be 32)", len(chaincode)) } - if pubkey == nil { - pubkey = pubkeyFromPrivkey(privkey, true) - } else if !(len(pubkey) == 65 || len(pubkey) == 33) { + if !(len(pubkey) == 65 || len(pubkey) == 33) { return nil, fmt.Errorf("invalid pubkey length %d", len(pubkey)) } @@ -219,6 +216,44 @@ func ChainedPrivKey(privkey, pubkey, chaincode []byte) ([]byte, error) { return pad(32, b), nil } +// ChainedPubKey deterministically generates a new public key using a +// previous public key and chaincode. pubkey must be 33 or 65 bytes, and +// chaincode must be 32 bytes long. +func ChainedPubKey(pubkey, chaincode []byte) ([]byte, error) { + if !(len(pubkey) == 65 || len(pubkey) == 33) { + return nil, fmt.Errorf("invalid pubkey length %v", len(pubkey)) + } + if len(chaincode) != 32 { + return nil, fmt.Errorf("invalid chaincode length %d (must be 32)", + len(chaincode)) + } + + xorbytes := make([]byte, 32) + chainMod := btcwire.DoubleSha256(pubkey) + for i := range xorbytes { + xorbytes[i] = chainMod[i] ^ chaincode[i] + } + + oldPk, err := btcec.ParsePubKey(pubkey, btcec.S256()) + if err != nil { + return nil, err + } + newX, newY := btcec.S256().ScalarMult(oldPk.X, oldPk.Y, xorbytes) + if err != nil { + return nil, err + } + newPk := &ecdsa.PublicKey{ + Curve: btcec.S256(), + X: newX, + Y: newY, + } + + if len(pubkey) == 65 { + return (*btcec.PublicKey)(newPk).SerializeUncompressed(), nil + } + return (*btcec.PublicKey)(newPk).SerializeCompressed(), nil +} + type version struct { major byte minor byte diff --git a/wallet/wallet_test.go b/wallet/wallet_test.go index 27ab05b..3790ef8 100644 --- a/wallet/wallet_test.go +++ b/wallet/wallet_test.go @@ -17,9 +17,13 @@ package wallet import ( + "bytes" + "crypto/ecdsa" "crypto/rand" + "github.com/conformal/btcec" "github.com/conformal/btcwire" "github.com/davecgh/go-spew/spew" + "math/big" "os" "reflect" "testing" @@ -133,3 +137,170 @@ func TestWalletCreationSerialization(t *testing.T) { return } } + +func TestChaining(t *testing.T) { + tests := []struct { + name string + cc []byte + origPrivateKey []byte + nextPrivateKeyUncompressed []byte + nextPrivateKeyCompressed []byte + nextPublicKeyUncompressed []byte + nextPublicKeyCompressed []byte + }{ + { + name: "chaintest 1", + cc: []byte("3318959fff419ab8b556facb3c429a86"), + origPrivateKey: []byte("5ffc975976eaaa1f7b179f384ebbc053"), + nextPrivateKeyUncompressed: []byte{ + 0xd3, 0xfe, 0x2e, 0x96, 0x44, 0x12, 0x2d, 0xaa, + 0x80, 0x8e, 0x36, 0x17, 0xb5, 0x9f, 0x8c, 0xd2, + 0x72, 0x8c, 0xaf, 0xf1, 0xdb, 0xd6, 0x4a, 0x92, + 0xd7, 0xc7, 0xee, 0x2b, 0x56, 0x34, 0xe2, 0x87, + }, + nextPrivateKeyCompressed: []byte{ + 0x08, 0x56, 0x7a, 0x1b, 0x89, 0x56, 0x2e, 0xfa, + 0xb4, 0x02, 0x59, 0x69, 0x10, 0xc3, 0x60, 0x1f, + 0x34, 0xf0, 0x55, 0x02, 0x8a, 0xbf, 0x37, 0xf5, + 0x22, 0x80, 0x9f, 0xd2, 0xe5, 0x42, 0x5b, 0x2d, + }, + nextPublicKeyUncompressed: []byte{ + 0x04, 0xdd, 0x70, 0x31, 0xa5, 0xf9, 0x06, 0x70, + 0xd3, 0x9a, 0x24, 0x5b, 0xd5, 0x73, 0xdd, 0xb6, + 0x15, 0x81, 0x0b, 0x78, 0x19, 0xbc, 0xc8, 0x26, + 0xc9, 0x16, 0x86, 0x73, 0xae, 0xe4, 0xc0, 0xed, + 0x39, 0x81, 0xb4, 0x86, 0x2d, 0x19, 0x8c, 0x67, + 0x9c, 0x93, 0x99, 0xf6, 0xd2, 0x3f, 0xd1, 0x53, + 0x9e, 0xed, 0xbd, 0x07, 0xd6, 0x4f, 0xa9, 0x81, + 0x61, 0x85, 0x46, 0x84, 0xb1, 0xa0, 0xed, 0xbc, + 0xa7, + }, + nextPublicKeyCompressed: []byte{ + 0x02, 0x2c, 0x48, 0x73, 0x37, 0x35, 0x74, 0x7f, + 0x05, 0x58, 0xc1, 0x4e, 0x0d, 0x18, 0xc2, 0xbf, + 0xcc, 0x83, 0xa2, 0x4d, 0x64, 0xab, 0xba, 0xea, + 0xeb, 0x4c, 0xcd, 0x4c, 0x0c, 0x21, 0xc4, 0x30, + 0x0f, + }, + }, + } + + for _, test := range tests { + // Create both uncompressed and compressed public keys for original + // private key. + origPubUncompressed := pubkeyFromPrivkey(test.origPrivateKey, false) + origPubCompressed := pubkeyFromPrivkey(test.origPrivateKey, true) + + // Create next chained private keys, chained from both the uncompressed + // and compressed pubkeys. + nextPrivUncompressed, err := ChainedPrivKey(test.origPrivateKey, + origPubUncompressed, test.cc) + if err != nil { + t.Errorf("%s: Uncompressed ChainedPrivKey failed: %v", test.name, err) + return + } + nextPrivCompressed, err := ChainedPrivKey(test.origPrivateKey, + origPubCompressed, test.cc) + if err != nil { + t.Errorf("%s: Compressed ChainedPrivKey failed: %v", test.name, err) + return + } + + // Verify that the new private keys match the expected values + // in the test case. + if !bytes.Equal(nextPrivUncompressed, test.nextPrivateKeyUncompressed) { + t.Errorf("%s: Next private key (from uncompressed pubkey) does not match expected.\nGot: %s\nExpected: %s", + test.name, spew.Sdump(nextPrivUncompressed), spew.Sdump(test.nextPrivateKeyUncompressed)) + return + } + if !bytes.Equal(nextPrivCompressed, test.nextPrivateKeyCompressed) { + t.Errorf("%s: Next private key (from compressed pubkey) does not match expected.\nGot: %s\nExpected: %s", + test.name, spew.Sdump(nextPrivCompressed), spew.Sdump(test.nextPrivateKeyCompressed)) + return + } + + // Create the next pubkeys generated from the next private keys. + nextPubUncompressedFromPriv := pubkeyFromPrivkey(nextPrivUncompressed, false) + nextPubCompressedFromPriv := pubkeyFromPrivkey(nextPrivCompressed, true) + + // Create the next pubkeys by chaining directly off the original + // pubkeys (without using the original's private key). + nextPubUncompressedFromPub, err := ChainedPubKey(origPubUncompressed, test.cc) + if err != nil { + t.Errorf("%s: Uncompressed ChainedPubKey failed: %v", test.name, err) + return + } + nextPubCompressedFromPub, err := ChainedPubKey(origPubCompressed, test.cc) + if err != nil { + t.Errorf("%s: Compressed ChainedPubKey failed: %v", test.name, err) + return + } + + // Public keys (used to generate the bitcoin address) MUST match. + if !bytes.Equal(nextPubUncompressedFromPriv, nextPubUncompressedFromPub) { + t.Errorf("%s: Uncompressed public keys do not match.", test.name) + } + if !bytes.Equal(nextPubCompressedFromPriv, nextPubCompressedFromPub) { + t.Errorf("%s: Compressed public keys do not match.", test.name) + } + + // Verify that all generated public keys match the expected + // values in the test case. + if !bytes.Equal(nextPubUncompressedFromPub, test.nextPublicKeyUncompressed) { + t.Errorf("%s: Next uncompressed public keys do not match expected value.\nGot: %s\nExpected: %s", + test.name, spew.Sdump(nextPubUncompressedFromPub), spew.Sdump(test.nextPublicKeyUncompressed)) + return + } + if !bytes.Equal(nextPubCompressedFromPub, test.nextPublicKeyCompressed) { + t.Errorf("%s: Next compressed public keys do not match expected value.\nGot: %s\nExpected: %s", + test.name, spew.Sdump(nextPubCompressedFromPub), spew.Sdump(test.nextPublicKeyCompressed)) + return + } + + // Sign data with the next private keys and verify signature with + // the next pubkeys. + pubkeyUncompressed, err := btcec.ParsePubKey(nextPubUncompressedFromPub, btcec.S256()) + if err != nil { + t.Errorf("%s: Unable to parse next uncompressed pubkey: %v", test.name, err) + return + } + pubkeyCompressed, err := btcec.ParsePubKey(nextPubCompressedFromPub, btcec.S256()) + if err != nil { + t.Errorf("%s: Unable to parse next compressed pubkey: %v", test.name, err) + return + } + privkeyUncompressed := &ecdsa.PrivateKey{ + PublicKey: *pubkeyUncompressed, + D: new(big.Int).SetBytes(nextPrivUncompressed), + } + privkeyCompressed := &ecdsa.PrivateKey{ + PublicKey: *pubkeyCompressed, + D: new(big.Int).SetBytes(nextPrivCompressed), + } + data := "String to sign." + r, s, err := ecdsa.Sign(rand.Reader, privkeyUncompressed, []byte(data)) + if err != nil { + t.Errorf("%s: Unable to sign data with next private key (chained from uncompressed pubkey): %v", + test.name, err) + return + } + ok := ecdsa.Verify(&privkeyUncompressed.PublicKey, []byte(data), r, s) + if !ok { + t.Errorf("%s: ecdsa verification failed for next keypair (chained from uncompressed pubkey).", + test.name) + return + } + r, s, err = ecdsa.Sign(rand.Reader, privkeyCompressed, []byte(data)) + if err != nil { + t.Errorf("%s: Unable to sign data with next private key (chained from compressed pubkey): %v", + test.name, err) + return + } + ok = ecdsa.Verify(&privkeyCompressed.PublicKey, []byte(data), r, s) + if !ok { + t.Errorf("%s: ecdsa verification failed for next keypair (chained from compressed pubkey).", + test.name) + return + } + } +}