LBRYFoundation/lbcwallet
1
0
Fork 0
mirror of https://github.com/LBRYFoundation/lbcwallet.git synced 2025-08-27 07:23:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Smarter locking for recording mined txs.

Browse source
This commit is contained in:
Josh Rickmar 2014-01-28 16:52:47 -05:00
parent 3ab33bafd7
commit d0b942d414
1 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
accountstore.go
View file

@ -130,7 +130,9 @@ func (store *AccountStore) RecordMinedTx(txid *btcwire.ShaHash,
defer store.RUnlock() defer store.RUnlock()
for _, account := range store.accounts { for _, account := range store.accounts {
account.TxStore.Lock() // The tx stores will be searched through while holding the
// reader lock, and the writer will only be grabbed if necessary.
account.TxStore.RLock()
// Search in reverse order. Since more recently-created // Search in reverse order. Since more recently-created
// transactions are appended to the end of the store, it's // transactions are appended to the end of the store, it's
@ -139,18 +141,25 @@ func (store *AccountStore) RecordMinedTx(txid *btcwire.ShaHash,
sendtx, ok := account.TxStore.s[i].(*tx.SendTx) sendtx, ok := account.TxStore.s[i].(*tx.SendTx)
if ok { if ok {
if bytes.Equal(txid.Bytes(), sendtx.TxID[:]) { if bytes.Equal(txid.Bytes(), sendtx.TxID[:]) {
// Unlock the held reader lock and wait for
// the writer lock.
account.TxStore.RUnlock()
account.TxStore.Lock()
copy(sendtx.BlockHash[:], blkhash.Bytes()) copy(sendtx.BlockHash[:], blkhash.Bytes())
sendtx.BlockHeight = blkheight sendtx.BlockHeight = blkheight
sendtx.BlockIndex = int32(blkindex) sendtx.BlockIndex = int32(blkindex)
sendtx.BlockTime = blktime sendtx.BlockTime = blktime
account.MarkDirtyTxStore() account.MarkDirtyTxStore()
// Release writer lock and return.
account.TxStore.Unlock() account.TxStore.Unlock()
return nil return nil
} }
} }
} }
account.TxStore.Unlock() account.TxStore.RUnlock()
} }
return errors.New("txid does not match any recorded sent transaction") return errors.New("txid does not match any recorded sent transaction")