LBRYFoundation/lbcwallet
1
0
Fork 0
mirror of https://github.com/LBRYFoundation/lbcwallet.git synced 2025-09-01 17:55:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

hack: trating all imported privatekey as non-watchonly

Browse source 
This is to unblock partner integration.

More comprehensive solution will be available soon.
This commit is contained in:
Roy Lee 2022-08-03 21:51:37 -07:00
parent 46f4df5a64
commit 893a820c65
1 changed files with 15 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
waddrmgr/manager.go
View file

@ -26,7 +26,7 @@ const (
// exceed the hardened child range of extended keys and it provides a // exceed the hardened child range of extended keys and it provides a
// reserved account at the top of the range for supporting imported // reserved account at the top of the range for supporting imported
// addresses. // addresses.
MaxAccountNum = hdkeychain.HardenedKeyStart - 2 // 2^31 - 2 MaxAccountNum = hdkeychain.HardenedKeyStart - 3 // 2^31 - 3
// MaxAddressesPerAccount is the maximum allowed number of addresses // MaxAddressesPerAccount is the maximum allowed number of addresses
// per account number. This value is based on the limitation of the // per account number. This value is based on the limitation of the
@ -37,11 +37,21 @@ const (
// addresses. This is useful since normal accounts are derived from // addresses. This is useful since normal accounts are derived from
// the root hierarchical deterministic key and imported addresses do // the root hierarchical deterministic key and imported addresses do
// not fit into that model. // not fit into that model.
ImportedAddrAccount = MaxAccountNum + 1 // 2^31 - 1 ImportedAddrAccount = hdkeychain.HardenedKeyStart - 1 // 2^31 - 1
// ImportedAddrAccountName is the name of the imported account. // ImportedAddrAccountName is the name of the imported account.
ImportedAddrAccountName = "imported" ImportedAddrAccountName = "imported"
// ImportedWatchonlyAddrAccount is the account number to use for all
// imported watchonly addresses, such as public keys and addresses.
// This is useful since normal accounts are derived from the root
// hierarchical deterministic key and imported addresses do not fit
// into that model.
ImportedWatchonlyAddrAccount = hdkeychain.HardenedKeyStart - 2 // 2^31 - 2
// ImportedWatchonlyAddrAccountName is the name of the imported watchonly account.
ImportedWatchonlyAddrAccountName = "imported-watchonly"
// DefaultAccountNum is the number of the default account. // DefaultAccountNum is the number of the default account.
DefaultAccountNum = 0 DefaultAccountNum = 0
@ -415,10 +425,10 @@ func (m *Manager) IsWatchOnlyAccount(ns walletdb.ReadBucket, keyScope KeyScope,
return true, nil return true, nil
} }
// Assume the default imported account has no private keys.
//
// TODO: Actually check whether it does.
if account == ImportedAddrAccount { if account == ImportedAddrAccount {
return false, nil
}
if account == ImportedWatchonlyAddrAccount {
return true, nil return true, nil
} }