LBRYFoundation/lbcwallet
1
0
Fork 0
mirror of https://github.com/LBRYFoundation/lbcwallet.git synced 2025-09-01 09:45:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #768 from guggero/send-outputs-watch-only

Browse source 
wallet: return unsigned TX in watch-only SendOutputs
This commit is contained in:
Olaoluwa Osuntokun 2021-10-07 17:00:44 -07:00 • committed by GitHub
commit 541a8512cc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
wallet/wallet.go
View file

@ -72,6 +72,10 @@ var (
// to true. // to true.
ErrTxLabelExists = errors.New("transaction already labelled") ErrTxLabelExists = errors.New("transaction already labelled")
// ErrTxUnsigned is returned when a transaction is created in the
// watch-only mode where we can select coins but not sign any inputs.
ErrTxUnsigned = errors.New("watch-only wallet, transaction not signed")
// Namespace bucket keys. // Namespace bucket keys.
waddrmgrNamespaceKey = []byte("waddrmgr") waddrmgrNamespaceKey = []byte("waddrmgr")
wtxmgrNamespaceKey = []byte("wtxmgr") wtxmgrNamespaceKey = []byte("wtxmgr")
@ -3209,6 +3213,13 @@ func (w *Wallet) SendOutputs(outputs []*wire.TxOut, keyScope *waddrmgr.KeyScope,
return nil, err return nil, err
} }
// If our wallet is read-only, we'll get a transaction with coins
// selected but no witness data. In such a case we need to inform our
// caller that they'll actually need to go ahead and sign the TX.
if w.Manager.WatchOnly() {
return createdTx.Tx, ErrTxUnsigned
}
txHash, err := w.reliablyPublishTransaction(createdTx.Tx, label) txHash, err := w.reliablyPublishTransaction(createdTx.Tx, label)
if err != nil { if err != nil {
return nil, err return nil, err