LBRYFoundation/lbcwallet
1
0
Fork 0
mirror of https://github.com/LBRYFoundation/lbcwallet.git synced 2025-08-23 17:47:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

wallet/wallet: prevent logging resend tx error if already accepted into

Browse source 
mempool
This commit is contained in:
Wilmer Paulino 2018-10-30 16:20:02 -07:00
parent ee93fa9871
commit 4976c84f8f
No known key found for this signature in database
GPG key ID: 6DF57B9F9514972F
1 changed files with 15 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
wallet/wallet.go
View file

@ -2786,6 +2786,15 @@ func (w *Wallet) resendUnminedTxs() {
for _, tx := range txs { for _, tx := range txs {
resp, err := chainClient.SendRawTransaction(tx, false) resp, err := chainClient.SendRawTransaction(tx, false)
if err != nil { if err != nil {
// If the transaction has already been accepted into the
// mempool, we can continue without logging the error.
switch {
case strings.Contains(err.Error(), "already have transaction"):
fallthrough
case strings.Contains(err.Error(), "txn-already-known"):
continue
}
log.Debugf("Could not resend transaction %v: %v", log.Debugf("Could not resend transaction %v: %v",
tx.TxHash(), err) tx.TxHash(), err)
@ -2817,9 +2826,12 @@ func (w *Wallet) resendUnminedTxs() {
// As the transaction was rejected, we'll attempt to // As the transaction was rejected, we'll attempt to
// remove the unmined transaction all together. // remove the unmined transaction all together.
// Otherwise, we'll keep attempting to rebroadcast // Otherwise, we'll keep attempting to rebroadcast this,
// this, and we may be computing our balance // and we may be computing our balance incorrectly if
// incorrectly if this tx credits or debits to us. // this transaction credits or debits to us.
//
// TODO(wilmer): if already confirmed, move to mined
// bucket - need to determine the confirmation block.
err := walletdb.Update(w.db, func(dbTx walletdb.ReadWriteTx) error { err := walletdb.Update(w.db, func(dbTx walletdb.ReadWriteTx) error {
txmgrNs := dbTx.ReadWriteBucket(wtxmgrNamespaceKey) txmgrNs := dbTx.ReadWriteBucket(wtxmgrNamespaceKey)