From caaa716939de13a7e18315ca3d378ec9579e5147 Mon Sep 17 00:00:00 2001
From: Akinwale Ariwodola <akinwale@gmail.com>
Date: Fri, 13 Dec 2019 15:30:55 +0100
Subject: [PATCH] add caching for api request

---
 src/Controller/MainController.php | 22 ++++++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)

diff --git a/src/Controller/MainController.php b/src/Controller/MainController.php
index 95c0b37..dbf94d0 100644
--- a/src/Controller/MainController.php
+++ b/src/Controller/MainController.php
@@ -7,6 +7,7 @@ use Mdanter\Ecc\Crypto\Signature\Signer;
 use Mdanter\Ecc\Serializer\PublicKey\PemPublicKeySerializer;
 use Mdanter\Ecc\Serializer\PublicKey\DerPublicKeySerializer;
 use Mdanter\Ecc\Serializer\Signature\DerSignatureSerializer;
+use Cake\Cache\Cache;
 use Cake\Core\Configure;
 use Cake\Datasource\ConnectionManager;
 use Cake\Log\Log;
@@ -156,7 +157,7 @@ class MainController extends AppController {
                 $endLimitId = $maxClaimId;
             }
 
-            $blockedList = json_decode(self::curl_get(self::blockedListUrl));
+            $blockedList = json_decode($this->_getBlockedList());
             $claims = $this->Claims->find()->select($this->Claims)->
                 select(['publisher' => 'C.name', 'publisher_transaction_hash_id' => 'C.transaction_hash_id', 'publisher_vout' => 'C.vout'])->
                 leftJoin(['C' => 'claim'], ['C.claim_id = Claims.publisher_id'])->
@@ -237,7 +238,7 @@ class MainController extends AppController {
             }
 
             // fetch blocked list
-            $blockedList = json_decode(self::curl_get(self::blockedListUrl));
+            $blockedList = json_decode($this->_getBlockedList());
             $claimChannel = $this->Claims->find()->select(['transaction_hash_id', 'vout'])->where(['claim_id' => $claim->publisher_id])->first();
             $claimIsBlocked = $this->_isClaimBlocked($claim, $claimChannel, $blockedList);
 
@@ -981,6 +982,11 @@ class MainController extends AppController {
     }
 
     private function _isClaimBlocked($claim, $claimChannel, $blockedList) {
+        if (!$blockedList || !isset($blockedList->data)) {
+            // invalid blockedList response
+            return false;
+        }
+
         $blockedOutpoints = $blockedList->data->outpoints;
         $claimIsBlocked = false;
         foreach ($blockedOutpoints as $outpoint) {
@@ -1002,4 +1008,16 @@ class MainController extends AppController {
 
         return $claimIsBlocked;
     }
+
+    private function _getBlockedList() {
+        $cachedList = Cache::read('blockedList', 'api_requests');
+        if ($cachedList !== false) {
+            return $cachedList;
+        }
+
+        // get the result from the api
+        $response = self::curl_get(self::blockedListUrl);
+        Cache::write('blockedList', $response, 'api_requests');
+        return $response;
+    }
 }