🍙 opening new tabs handled by the background now

- because firefox seem to block content script from openning new tabs in some cases

manifest.v2.json

@@ -18,6 +18,7 @@
         "https://odysee.com/",
         "https://madiator.com/",
         "https://finder.madiator.com/",
+        "tabs",
         "storage"
     ],
     "web_accessible_resources": [

manifest.v3.json

@@ -8,7 +8,8 @@
     "128": "assets/icons/wol/icon128.png"
   },
   "permissions": [
-    "storage"
+    "storage",
+    "tabs"
   ],
   "host_permissions": [
     "https://www.youtube.com/",

src/scripts/background.ts

@@ -2,23 +2,31 @@ import { resolveById } from "../modules/yt/urlResolve"
 
 const onGoingLbryPathnameRequest: Record<string, ReturnType<typeof resolveById>> = {}
 
-chrome.runtime.onMessage.addListener(({ json }, sender, sendResponse) => {
+chrome.runtime.onMessage.addListener(({ method, data }, sender, sendResponse) => {
   function resolve(result: Awaited<ReturnType<typeof resolveById>>) {
     sendResponse(JSON.stringify(result))
   }
   (async () => {
-    try {
+
-      const params: Parameters<typeof resolveById> = JSON.parse(json)
+    switch (method) {
-      // Don't create a new Promise for same ID until on going one is over.
+      case 'openTab':
-      const promise = onGoingLbryPathnameRequest[json] ?? (onGoingLbryPathnameRequest[json] = resolveById(...params))
+        chrome.tabs.create({ url: data })
-      console.log('lbrypathname request', params, await promise)
+        break
-      resolve(await promise)
+      case 'resolveUrl':
-    } catch (error) {
+        try {
-      sendResponse('error')
+          const params: Parameters<typeof resolveById> = JSON.parse(data)
-      console.error(error)
+          // Don't create a new Promise for same ID until on going one is over.
-    }
+          const promise = onGoingLbryPathnameRequest[data] ?? (onGoingLbryPathnameRequest[data] = resolveById(...params))
-    finally {
+          console.log('lbrypathname request', params, await promise)
-      delete onGoingLbryPathnameRequest[json]
+          resolve(await promise)
+        } catch (error) {
+          sendResponse('error')
+          console.error(error)
+        }
+        finally {
+          delete onGoingLbryPathnameRequest[data]
+        }
+        break
     }
   })()
 

src/scripts/ytContent.tsx

@@ -222,7 +222,7 @@ import { getExtensionSettingsAsync, getSourcePlatfromSettingsFromHostname, getTa
   }
   // We should get this from background, so the caching works and we don't get errors in the future if yt decides to impliment CORS
   async function requestResolveById(...params: Parameters<typeof resolveById>): ReturnType<typeof resolveById> {
-    const json = await new Promise<string | null | 'error'>((resolve) => chrome.runtime.sendMessage({ json: JSON.stringify(params) }, resolve))
+    const json = await new Promise<string | null | 'error'>((resolve) => chrome.runtime.sendMessage({ method: 'resolveUrl', data: JSON.stringify(params) }, resolve))
     if (json === 'error') {
       console.error("Background error on:", params)
       throw new Error("Background error.")
@@ -230,6 +230,11 @@ import { getExtensionSettingsAsync, getSourcePlatfromSettingsFromHostname, getTa
     return json ? JSON.parse(json) : null
   }
 
+  // Request new tab
+  async function openNewTab(url: URL) {
+    chrome.runtime.sendMessage({ method: 'openTab', data: url.href })
+  }
+
   function getLbryUrlByTarget(target: Target) {
     const url = new URL(`${target.platform.domainPrefix}${target.lbryPathname}`)
     if (target.time) url.searchParams.set('t', target.time.toFixed(0))
@@ -253,11 +258,13 @@ import { getExtensionSettingsAsync, getSourcePlatfromSettingsFromHostname, getTa
 
         const lbryURL = getLbryUrlByTarget(target)
 
-        // As soon as video play is ready and start playing, pause it.
+        if (source.type === 'video') {
-        findVideoElementAwait(source).then((videoElement) => {
+          // As soon as video play is ready and start playing, pause it.
-          videoElement.addEventListener('play', () => videoElement.pause(), { once: true })
+          findVideoElementAwait(source).then((videoElement) => {
-          videoElement.pause()
+            videoElement.addEventListener('play', () => videoElement.pause(), { once: true })
-        })
+            videoElement.pause()
+          })
+        }
 
         if (target.platform === targetPlatformSettings.app) {
           if (document.hidden) await new Promise((resolve) => document.addEventListener('visibilitychange', resolve, { once: true }))
@@ -266,7 +273,8 @@ import { getExtensionSettingsAsync, getSourcePlatfromSettingsFromHostname, getTa
           location.replace(lbryURL)
         }
         else {
-          open(lbryURL, '_blank')
+          openNewTab(lbryURL)
+
           if (window.history.length === 1) window.close()
           else window.history.back()
         }