🍱 On error background returns undefined but it should throw

This commit is contained in:
Shiba 2022-01-24 08:34:41 +00:00
parent 79ba91a1f1
commit 324d3800de
2 changed files with 4 additions and 2 deletions

View file

@ -17,7 +17,7 @@ async function lbryPathnameFromVideoId(videoId: string): Promise<string | void>
} }
chrome.runtime.onMessage.addListener(({ videoId }: { videoId: string }, sender, sendResponse) => { chrome.runtime.onMessage.addListener(({ videoId }: { videoId: string }, sender, sendResponse) => {
lbryPathnameFromVideoId(videoId).then((lbryPathname) => sendResponse(lbryPathname)) lbryPathnameFromVideoId(videoId).then((lbryPathname) => sendResponse(lbryPathname)).catch((err) => sendResponse(err))
return true return true
}) })

View file

@ -100,7 +100,9 @@ async function findVideoElement() {
// We should get this from background, so the caching works and we don't get errors in the future if yt decides to impliment CORS // We should get this from background, so the caching works and we don't get errors in the future if yt decides to impliment CORS
async function requestLbryPathname(videoId: string) { async function requestLbryPathname(videoId: string) {
return await new Promise<string | null>((resolve) => chrome.runtime.sendMessage({ videoId }, resolve)) const response = await new Promise<string | null | Error>((resolve) => chrome.runtime.sendMessage({ videoId }, resolve))
if (response instanceof Error) throw response
return response
} }
// Start // Start