Commit graph

556 commits

Author SHA1 Message Date
ThomasV
fc85dcead6 follow-up previous commit 2019-11-23 11:37:01 +01:00
ThomasV
6c62fb03ac fix #5733 2019-11-23 11:02:31 +01:00
ThomasV
61dfcba092 Refactor channel states:
- persisted states are saved
 - state transitions are checked
 - transient states are stored in channel.peer_state
 - new channel states: 'PREOPENING', 'FUNDED' and 'REDEEMED'
 - upgrade storage to version 21
2019-11-22 20:14:54 +01:00
SomberNight
6f246a83b3
qt coin selection: allow selecting an empty set
Using this, the user can force "bump fee" not to add new inputs.

closes #5719
2019-11-21 17:46:00 +01:00
SomberNight
11f54aee60
qt utxo list: spend_list is now a set (and renamed)
this is a small performance improvement ("if x in spend_list" was linear)
and the "order" of selected coins does not matter anyway
2019-11-21 17:21:54 +01:00
SomberNight
1526bc9ccf
qt: consistently show tooltip when copying to clipboard 2019-11-21 03:01:55 +01:00
Johann Bauer
9fe7917118
Qt: Remove unused color from color scheme 2019-11-20 21:11:41 +01:00
SomberNight
49284f716b
wallet: bump fee now supports coin selection
related: #5719
2019-11-20 18:43:05 +01:00
SomberNight
fec9677508
qt open channel: minor dialog fixes 2019-11-20 18:00:45 +01:00
SomberNight
cd9477c0da
ln: qt channel open: fix max channel size 2019-11-20 17:45:28 +01:00
SomberNight
4057140e6a
lightning qr codes: more robust parsing
kivy qr code handling did not accept "lightning:" prefix or uppercase
2019-11-20 03:21:59 +01:00
SomberNight
d1c262def0
qt tx dialog: small clean-up in constructors 2019-11-19 22:17:52 +01:00
SomberNight
97056ae44d
qt send tab: subtract 2fa fee when clicking "spend max" 2019-11-19 21:22:49 +01:00
SomberNight
ca6654c102
qt send tab: don't allow paying multiple invoices that spend max '!' 2019-11-19 20:26:50 +01:00
SomberNight
710e9621b5
qt tx dialog: allow blanking feerate
Previously it was impossible to rm the last character in feerate_edit.
e.g. if you held down "backspace", we would keep refilling the field as soon
as it became empty.
2019-11-19 20:13:16 +01:00
SomberNight
13b858ab26
qt tx dialog: disable "Finalize" btn if tx is None
e.g. NotEnoughFunds due to too high fee
2019-11-19 19:35:57 +01:00
SomberNight
66ddedb97e
qt tx dialog: small fee edit fix
scenario: enter extremely high feerate (which we cannot satisfy) then click into fee_edit.
At that moment, fee_edit is empty and both feerate_edit and fee_edit are considered frozen.
As fee_edit has priority, we would construct a tx with default fee.
Now, instead, we won't construct this default fee tx ~as if the click to fee_edit did not happen.
2019-11-19 19:29:10 +01:00
SomberNight
8bd27851a4
qt tx dialog: only allow "save as local" for complete txns 2019-11-19 18:41:44 +01:00
SomberNight
aa3d817ef2
qt: clean-up imports 2019-11-18 20:56:49 +01:00
ThomasV
aa37979100 fix #5761 2019-11-18 10:22:20 +01:00
ThomasV
b9cf095e1a fix #5761 2019-11-18 05:48:21 +01:00
ThomasV
47e0b4cd02 fix #5765 2019-11-18 05:12:13 +01:00
ThomasV
6b9971a466 fix #5767 2019-11-17 19:29:48 +01:00
ThomasV
0a8f511340 fix #5772 2019-11-17 19:25:11 +01:00
ThomasV
a453189d37 fix #5766 2019-11-17 17:08:09 +01:00
ThomasV
af21a4a8d6 fix #5770 2019-11-17 16:58:35 +01:00
ThomasV
3083237363
Merge pull request #5768 from lukechilds/ln-negative-red
Show outgoing Lightning payments with red description
2019-11-17 13:58:16 +01:00
ThomasV
e74f7e7b42 fix #5764 2019-11-17 13:48:19 +01:00
Luke Childs
bcae8ed1ad Show outgoing Lightning paymenst with red description 2019-11-17 15:28:17 +07:00
SomberNight
6e3875ceab
fix qt seed dialog (follow-up af86c7e3fd) 2019-11-15 23:50:05 +01:00
ThomasV
c2c291dd3a fix #5757 2019-11-14 10:30:06 +01:00
ThomasV
78813dcb7d Pass make_tx function to ConfirmTxDialog
- allow 'spend max' when opening a channel (fixes #5698)
 - display amount minus fee when 'max' buttons are pressed
 - estimate fee of channel funding using a template with dummy address
2019-11-14 10:20:19 +01:00
SomberNight
970bd4e95f
qt coin control: introduce second status bar 2019-11-13 19:09:07 +01:00
SomberNight
800c05b32f
qt addresses tab: fix "Spend from" 2019-11-13 05:46:45 +01:00
SomberNight
0c0a6b2145
TxDialog: fix hooks. only show psbt widgets when applicable.
users of 'transaction_dialog' were assuming that dialog.tx is already set
2019-11-12 23:05:01 +01:00
SomberNight
05c496edd1
PreviewTxDialog: small UI changes 2019-11-12 23:04:57 +01:00
SomberNight
9627f32e08
qt utxo list fixes 2019-11-12 23:04:54 +01:00
SomberNight
74790c16f9
PreviewTxDialog: fix RBF checkbox 2019-11-12 23:04:50 +01:00
SomberNight
e7efc3657b
fix Qt tx dialog randomly disappearing (due to gc) 2019-11-12 23:04:47 +01:00
SomberNight
1e77562bcb
qt/confirm_tx_dialog: fix qt warning
QLayout::addChildLayout: layout "" already has a parent
2019-11-12 23:04:42 +01:00
ThomasV
8c3af39a9b add option to pay multiple invoices 2019-11-12 18:37:35 +01:00
ThomasV
dd6cb2caf7 GUI: Separate output selection and transaction finalization.
- Output selection belongs in the Send tab.
 - Tx finalization is performed in a confirmation dialog
   (ConfirmTxDialog or PreviewTxDialog)
 - the fee slider is shown in the confirmation dialog
 - coin control works by selecting items in the coins tab
 - user can save invoices and pay them later
 - ConfirmTxDialog is used when opening channels and sweeping keys
2019-11-12 14:42:06 +01:00
SomberNight
2fec17760d
qt address list: check internal address corruption when copying address
regressing following c721e880d0

note that place_text_on_clipboard is overridden in AddressList
2019-11-11 15:51:23 +01:00
ThomasV
5773097b08 rename 'copy column' to 'copy' 2019-11-10 07:55:37 +01:00
SomberNight
365aa189f2
qt FileDialogs for transactions: better file extension filter 2019-11-08 15:22:11 +01:00
SomberNight
9ff7d2c5a7
transactions (qt): fix opening raw bytes files
(both when trying to "load tx from file", and "load tx from text" > "browse file")
2019-11-08 15:10:54 +01:00
SomberNight
27df235c26
transactions: reading QR codes: clean-up and accept all encodings 2019-11-07 06:33:15 +01:00
SomberNight
aa518c0ea5
psbt: allow insecure signing of legacy UTXOs without full previous tx
When "importing" a psbt, we accept witness utxos even for legacy inputs
(warning shown to user in gui).
When "exporting" a psbt, we follow the spec; except when exporting as a QR code,
in which case we include witness utxos for all inputs.
This makes QR codes for psbts with legacy inputs feasible, just like they
were before, with our custom tx serialization format (with the same risk,
of burning coins as miner fees).
2019-11-07 02:40:10 +01:00
SomberNight
c8c1ea9c86
qt tx dialog: add export options for coinjoins and for coldcard 2019-11-04 22:25:06 +01:00
SomberNight
d872be7f6b
psbt: don't put xpubs and full paths into tx by def; only while signing 2019-11-04 22:25:02 +01:00