ThomasV
8e08ca7cb1
simplify network callbacks in lnworker
2019-11-22 15:06:37 +01:00
ThomasV
b469df5283
check channel funding_tx amount and script in save_short_channel_id
2019-11-21 20:16:04 +01:00
SomberNight
c2b0039935
bitcoin.py: remove some remnants of TYPE_ADDRESS, TYPE_SCRIPT
2019-11-21 18:51:38 +01:00
SomberNight
03cc63205f
trivial: use logger.exception instead of traceback.print_exc
2019-11-21 17:55:00 +01:00
SomberNight
6f246a83b3
qt coin selection: allow selecting an empty set
...
Using this, the user can force "bump fee" not to add new inputs.
closes #5719
2019-11-21 17:46:00 +01:00
SomberNight
11f54aee60
qt utxo list: spend_list is now a set (and renamed)
...
this is a small performance improvement ("if x in spend_list" was linear)
and the "order" of selected coins does not matter anyway
2019-11-21 17:21:54 +01:00
SomberNight
216d9e3c4d
lnpeer: (fix) force_close_channel was not awaited in some cases
2019-11-21 16:37:43 +01:00
ghost43
d5b27e5be1
Merge pull request #5787 from xaya/http-request-auth
...
Return 401 from RPC server for missing auth
2019-11-21 15:21:17 +00:00
Daniel Kraft
423c4b0695
Return 401 from RPC server for missing auth.
...
When no (supported) authentication is passed to the JSON-RPC server,
return a 401 HTTP error code instead of 403. This indicates to the
client that authentication is required, and also requests that to be
sent using the "basic" method. The previously-returned code 403 is now
only returned if authentication is passed but not valid.
There are some JSON-RPC clients out there that only send authentication
after a 401 code requested it. Those fail to connect to the Electrum
RPC interface even if the correct password is configured. Those same
clients can e.g. connect to Bitcoin Core successfully, which already
implements logic matching this change.
See also https://stackoverflow.com/questions/3297048/403-forbidden-vs-401-unauthorized-http-responses .
2019-11-21 15:16:37 +01:00
SomberNight
6b195437ed
wallet: "future" txns num conf is now negative
...
flipped the sign so that TxMinedInfo.conf can be consistently used in inequalities
2019-11-21 05:01:59 +01:00
SomberNight
1526bc9ccf
qt: consistently show tooltip when copying to clipboard
2019-11-21 03:01:55 +01:00
Johann Bauer
9fe7917118
Qt: Remove unused color from color scheme
2019-11-20 21:11:41 +01:00
SomberNight
06de2660cf
kivy: support invoices with "max" amount
...
closes #5781
2019-11-20 19:29:29 +01:00
SomberNight
49284f716b
wallet: bump fee now supports coin selection
...
related: #5719
2019-11-20 18:43:05 +01:00
SomberNight
fec9677508
qt open channel: minor dialog fixes
2019-11-20 18:00:45 +01:00
SomberNight
cd9477c0da
ln: qt channel open: fix max channel size
2019-11-20 17:45:28 +01:00
SomberNight
ae04434206
ln: update list of fallback nodes
...
with some popular nodes from 1ml.com
2019-11-20 17:14:14 +01:00
SomberNight
4057140e6a
lightning qr codes: more robust parsing
...
kivy qr code handling did not accept "lightning:" prefix or uppercase
2019-11-20 03:21:59 +01:00
SomberNight
d1c262def0
qt tx dialog: small clean-up in constructors
2019-11-19 22:17:52 +01:00
SomberNight
97056ae44d
qt send tab: subtract 2fa fee when clicking "spend max"
2019-11-19 21:22:49 +01:00
SomberNight
ca6654c102
qt send tab: don't allow paying multiple invoices that spend max '!'
2019-11-19 20:26:50 +01:00
SomberNight
710e9621b5
qt tx dialog: allow blanking feerate
...
Previously it was impossible to rm the last character in feerate_edit.
e.g. if you held down "backspace", we would keep refilling the field as soon
as it became empty.
2019-11-19 20:13:16 +01:00
SomberNight
13b858ab26
qt tx dialog: disable "Finalize" btn if tx is None
...
e.g. NotEnoughFunds due to too high fee
2019-11-19 19:35:57 +01:00
SomberNight
66ddedb97e
qt tx dialog: small fee edit fix
...
scenario: enter extremely high feerate (which we cannot satisfy) then click into fee_edit.
At that moment, fee_edit is empty and both feerate_edit and fee_edit are considered frozen.
As fee_edit has priority, we would construct a tx with default fee.
Now, instead, we won't construct this default fee tx ~as if the click to fee_edit did not happen.
2019-11-19 19:29:10 +01:00
SomberNight
8bd27851a4
qt tx dialog: only allow "save as local" for complete txns
2019-11-19 18:41:44 +01:00
SomberNight
aa3d817ef2
qt: clean-up imports
2019-11-18 20:56:49 +01:00
SomberNight
b8e4ce9ba1
hardware wallets: handle when label is None
...
follow-up 56c3de0e1e
2019-11-18 18:13:26 +01:00
ThomasV
aa37979100
fix #5761
2019-11-18 10:22:20 +01:00
ThomasV
b9cf095e1a
fix #5761
2019-11-18 05:48:21 +01:00
ThomasV
ade47e331a
Merge branch 'master' of github.com:spesmilo/electrum
2019-11-18 05:12:25 +01:00
ThomasV
47e0b4cd02
fix #5765
2019-11-18 05:12:13 +01:00
ghost43
f2ca651dc4
Merge pull request #5775 from JeremyRand/resolver-wallet
...
Fix missing wallet argument to _resolver
2019-11-18 02:11:06 +00:00
JeremyRand
643bc9d802
Fix missing wallet argument to _resolver
2019-11-18 01:31:33 +00:00
ThomasV
6b9971a466
fix #5767
2019-11-17 19:29:48 +01:00
ThomasV
0a8f511340
fix #5772
2019-11-17 19:25:11 +01:00
ThomasV
a453189d37
fix #5766
2019-11-17 17:08:09 +01:00
ThomasV
af21a4a8d6
fix #5770
2019-11-17 16:58:35 +01:00
ThomasV
3083237363
Merge pull request #5768 from lukechilds/ln-negative-red
...
Show outgoing Lightning payments with red description
2019-11-17 13:58:16 +01:00
ThomasV
e74f7e7b42
fix #5764
2019-11-17 13:48:19 +01:00
Luke Childs
bcae8ed1ad
Show outgoing Lightning paymenst with red description
2019-11-17 15:28:17 +07:00
SomberNight
cbd146ad15
hardware wallets: detect if label changed and update it in wallet file
2019-11-17 01:17:38 +01:00
SomberNight
56c3de0e1e
hardware wallets: better handle label collision when selecting device
...
related: #5759
2019-11-17 01:15:44 +01:00
SomberNight
6e3875ceab
fix qt seed dialog (follow-up af86c7e3fd)
2019-11-15 23:50:05 +01:00
SomberNight
600b26eed6
hardware wallets: pull udev rules into our repository
...
README.md heavily based on 060c7fc618/hwilib/udev/README.md
2019-11-15 23:43:43 +01:00
SomberNight
6ebbaa60ef
old_mnemonic: speed up mn_decode
...
mn_decode is used by mnemonic.make_seed which now takes around 25% less time
2019-11-15 12:08:06 +01:00
ghost43
bc4f22503f
Merge pull request #5758 from mbarkhau/master
...
Mnemonic performance improvements
2019-11-15 09:59:40 +00:00
Manuel Barkhau
af86c7e3fd
fix: cache wordlists
2019-11-14 18:57:18 +00:00
Manuel Barkhau
b3f913340c
make Mnemonic.mnemonic_decode faster
...
list.index(word) is O(n)
dict[word] is O(log(n))
This makes a difference for Mnemonic.make_seed which
calls self.mnemonic_decode repeatedly.
2019-11-14 18:54:14 +00:00
ThomasV
c2c291dd3a
fix #5757
2019-11-14 10:30:06 +01:00
ThomasV
78813dcb7d
Pass make_tx function to ConfirmTxDialog
...
- allow 'spend max' when opening a channel (fixes #5698 )
- display amount minus fee when 'max' buttons are pressed
- estimate fee of channel funding using a template with dummy address
2019-11-14 10:20:19 +01:00
