SomberNight
d0a43662bd
wallet: make "increase fee" RBF logic smarter
...
There are now two internal strategies to bump the fee of a txn.
bump fee method 1: keep all inputs, keep all not is_mine outputs,
allow adding new inputs
bump fee method 2: keep all inputs, no new inputs are added,
allow decreasing and removing outputs (change is decreased first)
Method 2 is less "safe" as it might end up decreasing e.g. a payment to a merchant;
but e.g. if the user has sent "Max" previously, this is the only way to RBF.
We try method 1 first, and fail-over to method 2.
Previous versions always used method 2.
fixes #3652
2019-06-20 22:42:48 +02:00
SomberNight
0553ab7f3f
follow-up prev
...
PaymentRequest.error is really not intuitive.........
2019-06-05 19:05:58 +02:00
SomberNight
d2de8de356
qt payment requests: fix some races
...
closes #5283 , #5407 , #5121
2019-06-05 16:29:33 +02:00
SomberNight
41802d8094
qt receive tab: "receive address" is now coloured red if already used
...
closes #3812
closes #5374
2019-05-27 20:24:09 +02:00
SomberNight
158090bf8b
util.parse_URI: more granular exceptions
...
related: #5376
first report in #5376 was generated with these changes;
before, the exception was caught and a toast displayed "Not a Bitcoin URI"
2019-05-25 04:55:36 +02:00
SomberNight
db9a9bbf25
qt settings: restart needed after toggling log_to_file
2019-05-21 20:57:29 +02:00
SomberNight
d3f65e24e1
kivy: warn user during "Send" if high fee (change condition)
...
Specifically, warning was previously triggered if fee > 1 mBTC;
now it is unified with Qt, warning is triggered if feerate > 600 sat/byte.
2019-05-17 20:10:10 +02:00
SomberNight
099315013e
(trivial) qt main_window: rm unnecessary indendation
2019-05-14 00:03:50 +02:00
SomberNight
f6dfcccf8c
qt: factor out util.MessageBoxMixin.msg_box into function and use it
...
so these dialogs also get our custom default settings applied,
e.g. their text is selectable by mouse
2019-05-13 23:59:29 +02:00
SomberNight
a59e3efd3e
qt send tab: fix tx_size and fee calc in case of payment requests
...
do_update_fee() was always setting
`outputs = self.payto_e.get_outputs(...)`
but this only works `if not self.payment_request`
Minor refactor to re-use logic instead of duplicating code.
2019-05-13 02:52:22 +02:00
SomberNight
f6a7e6ec7d
logging: don't log to file by default
...
Leaking addresses/pubkeys/txids is a privacy leak...
but with lightning, logging should be enabled by default, as otherwise
issues would be sometimes impossible to debug...
Well, disable it for now.
2019-05-08 16:52:04 +02:00
SomberNight
0e6cf153d7
synchronizer: show progress in GUI
2019-05-07 17:58:06 +02:00
SomberNight
c80c3596a7
logging: expose 'disablefilelogging' option in Qt preferences
2019-05-04 18:30:26 +02:00
SomberNight
a7b13f4876
logging: make console log lines shorter
2019-05-02 15:19:11 +02:00
SomberNight
3385a94753
logging: basics
2019-05-02 15:19:03 +02:00
SomberNight
19ced234aa
qt: maybe batch do_update_fee() on network fee update
2019-05-02 03:09:47 +02:00
SomberNight
99f9a1b484
qt: warn user if in testnet mode
...
closes #5295
2019-04-28 06:31:01 +02:00
ghost43
a6762ffebc
Merge pull request #5272 from SomberNight/issue_4638_2
...
sweep/import key: disallow uncompressed segwit
2019-04-25 14:25:46 +02:00
SomberNight
8ad0c248a5
cpfp: include fee already paid by parent tx in calculation
...
fixes #5244
2019-04-20 02:09:45 +02:00
SomberNight
a1d98d4331
sweep/import key: show error in Qt GUI to user as tooltip
2019-04-19 00:15:45 +02:00
ThomasV
9b4e490e3c
leave max_button pressed ( fix #5251 )
2019-04-17 14:18:36 +02:00
zebra-lucky
df6cba5af8
fix sign message not accept rich text ( #5210 )
...
* fix sign message not accept rich text
* set no rich also to signature/encrypt msg/encrypted fields
2019-03-20 00:46:19 +01:00
SomberNight
752c518bdc
add option to freeze individual UTXOs
...
based on cculianu's work in Electron-Cash/Electron-Cash@fd910cffc8
2019-03-11 18:46:29 +01:00
SomberNight
cd40f2c9b7
trivial wallet clean-up
2019-03-10 18:47:23 +01:00
SomberNight
0ac2ca8ed3
qt "new transaction" notifications: change wording
...
closes #5171
2019-03-02 19:25:54 +01:00
SomberNight
8b2c586d30
post-storage_db-merge fixups
2019-03-01 14:14:30 +01:00
SomberNight
4ef3eda8da
util: mv create_URI to create_bip21_uri, and small clean-up
2019-02-20 21:19:03 +01:00
SomberNight
026448837f
no more "import *"
...
fixes #5101
fixes #5105
2019-02-11 20:21:24 +01:00
ThomasV
1da1f0bfea
fix #4984
2019-02-08 11:17:48 +01:00
SomberNight
67d080b34a
mv qt update checker to its own file
2019-02-04 20:27:03 +01:00
SomberNight
16bac5fd73
rm qt icons file
...
so we don't need pyrcc5, which is not deterministic,
and so we don't need the submodule for the icons
based on electrumsv/electrumsv@bf8802c2ea
2019-02-01 20:15:28 +01:00
SomberNight
31c08db909
qt update notifications: make url clickable; prevent multiple dialogs
2019-01-27 14:42:37 +01:00
Johann Bauer
34c99c3b36
[Qt] Add optional update notifications
2019-01-25 18:16:32 +01:00
ThomasV
920d4c2b27
simplify qr window
2019-01-23 17:17:13 +01:00
SomberNight
5403ae7687
network: sanitize tx broadcast response
2019-01-18 20:25:21 +01:00
SomberNight
d77e4d8f5d
exception formatting: use repr(e) instead of str(e) in messages
...
repr(e) is more useful
2019-01-17 17:16:19 +01:00
Johann Bauer
019566b383
Change string formatting to improve translation
...
For example, "Hide Console" would be "Konsole anzeigen" in German.
Currently, translators can only show "Anzeigen Konsole" which doesn't
make much sense.
2019-01-12 21:58:21 +01:00
Johann Bauer
bde655ae00
Qt: Show pointer cursor for status bar buttons
2019-01-01 20:39:27 +01:00
SomberNight
5dc240d4ed
qt: show_message and friends display plaintext by default
2018-12-21 20:46:47 +01:00
SomberNight
5248613e9d
gui: prepend broadcast_transaction errors with explanatory message
2018-12-21 20:44:38 +01:00
SomberNight
1b7672f70e
qt: fix invoices tab
...
closes #4941
2018-12-20 01:09:16 +01:00
Calin Culianu
14363f8f2f
[Qt] Got rid of qt.util.Timer class and instead replaced the functionality with the more efficient QTimer. Also added disconnection from the timer on window close.
...
(cherry picked from 19a21eb08d
2018-12-13 16:00:44 +01:00
ThomasV
3184d6f369
simplify previous commit
2018-12-13 12:10:36 +01:00
SomberNight
ef94af950c
wallet: try detecting internal address corruption
2018-12-12 20:50:53 +01:00
SomberNight
363dd12a2a
qt: try even harder not to crash whole app on first start
2018-12-11 21:29:23 +01:00
ThomasV
e35ed17200
remove call to undefined method refresh_headers
2018-12-10 13:07:03 +01:00
SomberNight
ca1043ffda
qt history list: hide columns sooner
...
while wallet was starting up "hidden columns" were visible
2018-12-10 09:31:53 +01:00
SomberNight
0d755b86ab
qt address dialog: HistoryModel needs reference to correct HistoryList
...
refresh() was hiding/showing the headers of the main HistoryList
2018-12-10 09:31:52 +01:00
SomberNight
a99b92f613
qt history list: optimise fee histogram induced refresh
2018-12-10 09:31:51 +01:00
SomberNight
696db310a5
qt history list: optimise update_item (tx mined status)
2018-12-10 09:31:50 +01:00
