LBRYFoundation/LBRY-Vault
1
0
Fork 0
mirror of https://github.com/LBRYFoundation/LBRY-Vault.git synced 2025-08-23 17:47:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove early return in create_sweeptxs_for_our_ctx.

Browse source 
- This was added because we did not store the complete htlc history.
 - It makes the result dependent on the current channel state
 - That creates a race condition in sweep_info, because the result is cached.
 - As a result, test_breach_with_spent_htlc was randomly failing.
This commit is contained in:
ThomasV 2019-08-30 09:11:54 +02:00
parent 5f817770af
commit d0cfb3ae12
1 changed files with 0 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
electrum/lnsweep.py
View file

@ -186,11 +186,6 @@ def create_sweeptxs_for_our_ctx(chan: 'Channel', ctx: Transaction, ctn: int,
return return
# we have to_local, to_remote. # we have to_local, to_remote.
# other outputs are htlcs # other outputs are htlcs
# if they are spent, we need to generate the script
# so, second-stage htlc sweep should not be returned here
if ctn < chan.get_oldest_unrevoked_ctn(LOCAL):
_logger.info("we breached.")
return {}
txs = {} txs = {}
# to_local # to_local
output_idx = ctx.get_output_idx_from_address(to_local_address) output_idx = ctx.get_output_idx_from_address(to_local_address)