LBRYFoundation/LBRY-Vault
1
0
Fork 0
mirror of https://github.com/LBRYFoundation/LBRY-Vault.git synced 2025-09-03 20:35:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

HardwareClientBase: provide default implementation for label

Browse source 
and add warning about placeholders
This commit is contained in:
SomberNight 2020-04-08 18:28:21 +02:00
parent db1ff4915f
commit bf067f7558
No known key found for this signature in database
GPG key ID: B33B5F232C6271E9
3 changed files with 3 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
electrum/plugins/digitalbitbox/digitalbitbox.py
View file

@ -88,10 +88,6 @@ class DigitalBitbox_Client(HardwareClientBase):
pass
def label(self):
return " "
def is_pairable(self):
return True

4
electrum/plugins/hw_wallet/plugin.py
View file

@ -196,7 +196,9 @@ class HardwareClientBase:
and they are also used as a fallback to distinguish devices programmatically.
So ideally, different devices would have different labels.
"""
raise NotImplementedError()
# When returning a constant here (i.e. not implementing the method in the way
# it is supposed to work), make sure the return value is in electrum.plugin.PLACEHOLDER_HW_CLIENT_LABELS
return " "
def get_soft_device_id(self) -> Optional[str]:
"""An id-like string that is used to distinguish devices programmatically.

3
electrum/plugins/ledger/ledger.py
View file

@ -80,9 +80,6 @@ class Ledger_Client(HardwareClientBase):
def is_initialized(self):
return True
def label(self):
return ""
def get_soft_device_id(self):
if self._soft_device_id is None:
# modern ledger can provide xpub without user interaction