From b1d23896562d0311b3bbcb56588a67f99d76047c Mon Sep 17 00:00:00 2001 From: SomberNight Date: Fri, 17 Apr 2020 19:37:05 +0200 Subject: [PATCH] hww: stop keystore.thread when closing wallet previously left running? Qt on macOS was complaining: ``` QThread: Destroyed while thread is still running Abort trap: 6 ``` --- electrum/plugins/hw_wallet/plugin.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/electrum/plugins/hw_wallet/plugin.py b/electrum/plugins/hw_wallet/plugin.py index 512f0ca6e..00fdcabad 100644 --- a/electrum/plugins/hw_wallet/plugin.py +++ b/electrum/plugins/hw_wallet/plugin.py @@ -81,6 +81,8 @@ class HW_PluginBase(BasePlugin): for keystore in wallet.get_keystores(): if isinstance(keystore, self.keystore_class): self.device_manager().unpair_xpub(keystore.xpub) + if keystore.thread: + keystore.thread.stop() def scan_and_create_client_for_device(self, *, device_id: str, wizard: 'BaseWizard') -> 'HardwareClientBase': devmgr = self.device_manager()