LBRYFoundation/LBRY-Vault
1
0
Fork 0
mirror of https://github.com/LBRYFoundation/LBRY-Vault.git synced 2025-08-31 01:11:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

interface.is_server_ca_signed: don't rely on assert

Browse source
This commit is contained in:
SomberNight 2019-02-18 18:00:54 +01:00
parent 2f11216986
commit 0bf0b1d20b
No known key found for this signature in database
GPG key ID: B33B5F232C6271E9
1 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
electrum/interface.py
View file

@ -217,12 +217,19 @@ class Interface(PrintError):
else: else:
self.proxy = None self.proxy = None
async def is_server_ca_signed(self, sslc): async def is_server_ca_signed(self, ca_ssl_context):
"""Given a CA enforcing SSL context, returns True if the connection
can be established. Returns False if the server has a self-signed
certificate but otherwise is okay. Any other failures raise.
"""
try: try:
await self.open_session(sslc, exit_early=True) await self.open_session(ca_ssl_context, exit_early=True)
except ssl.SSLError as e: except ssl.SSLError as e:
assert e.reason == 'CERTIFICATE_VERIFY_FAILED' if e.reason == 'CERTIFICATE_VERIFY_FAILED':
# failures due to self-signed certs are normal
return False return False
# e.g. too weak crypto
raise
return True return True
async def _try_saving_ssl_cert_for_first_time(self, ca_ssl_context): async def _try_saving_ssl_cert_for_first_time(self, ca_ssl_context):